* [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock
@ 2021-03-29 9:53 Shixin Liu
2021-03-29 9:53 ` [PATCH -next 2/2] mtip32xx: use LIST_HEAD() for list_head Shixin Liu
2021-03-29 13:39 ` [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Shixin Liu @ 2021-03-29 9:53 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, linux-kernel, Shixin Liu
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Signed-off-by: Shixin Liu <liushixin2@huawei.com>
---
drivers/block/mtip32xx/mtip32xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 3be0dbc674bd..39e3280030d6 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -97,7 +97,7 @@ static int instance;
static struct list_head online_list;
static struct list_head removing_list;
-static spinlock_t dev_lock;
+static DEFINE_SPINLOCK(dev_lock);
/*
* Global variable used to hold the major block device number
@@ -4363,8 +4363,6 @@ static int __init mtip_init(void)
pr_info(MTIP_DRV_NAME " Version " MTIP_DRV_VERSION "\n");
- spin_lock_init(&dev_lock);
-
INIT_LIST_HEAD(&online_list);
INIT_LIST_HEAD(&removing_list);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next 2/2] mtip32xx: use LIST_HEAD() for list_head
2021-03-29 9:53 [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock Shixin Liu
@ 2021-03-29 9:53 ` Shixin Liu
2021-03-29 13:39 ` [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Shixin Liu @ 2021-03-29 9:53 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, linux-kernel, Shixin Liu
There's no need to declare a list and then init it manually,
just use the LIST_HEAD() macro.
Signed-off-by: Shixin Liu <liushixin2@huawei.com>
---
drivers/block/mtip32xx/mtip32xx.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 39e3280030d6..07c8b99b88c1 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -95,8 +95,8 @@
/* Device instance number, incremented each time a device is probed. */
static int instance;
-static struct list_head online_list;
-static struct list_head removing_list;
+static LIST_HEAD(online_list);
+static LIST_HEAD(removing_list);
static DEFINE_SPINLOCK(dev_lock);
/*
@@ -4363,9 +4363,6 @@ static int __init mtip_init(void)
pr_info(MTIP_DRV_NAME " Version " MTIP_DRV_VERSION "\n");
- INIT_LIST_HEAD(&online_list);
- INIT_LIST_HEAD(&removing_list);
-
/* Allocate a major block device number to use with this driver. */
error = register_blkdev(0, MTIP_DRV_NAME);
if (error <= 0) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock
2021-03-29 9:53 [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock Shixin Liu
2021-03-29 9:53 ` [PATCH -next 2/2] mtip32xx: use LIST_HEAD() for list_head Shixin Liu
@ 2021-03-29 13:39 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-03-29 13:39 UTC (permalink / raw)
To: Shixin Liu; +Cc: linux-block, linux-kernel
On 3/29/21 3:53 AM, Shixin Liu wrote:
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
Applied both, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-29 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-29 9:53 [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock Shixin Liu
2021-03-29 9:53 ` [PATCH -next 2/2] mtip32xx: use LIST_HEAD() for list_head Shixin Liu
2021-03-29 13:39 ` [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox