From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH] block: default BLOCK_LEGACY_AUTOLOAD to y
Date: Fri, 25 Feb 2022 19:14:40 +0100 [thread overview]
Message-ID: <20220225181440.1351591-1-hch@lst.de> (raw)
As Luis reported, losetup currently doesn't properly create the loop
device without this if the device node already exists because old
scripts created it manually. So default to y for now and remove the
aggressive removal schedule.
Reported-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/Kconfig | 8 +++-----
block/bdev.c | 2 +-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/block/Kconfig b/block/Kconfig
index 168b873eb666d..7eb5d6d53b3fc 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -28,15 +28,13 @@ if BLOCK
config BLOCK_LEGACY_AUTOLOAD
bool "Legacy autoloading support"
+ default y
help
Enable loading modules and creating block device instances based on
accesses through their device special file. This is a historic Linux
feature and makes no sense in a udev world where device files are
- created on demand.
-
- Say N here unless booting or other functionality broke without it, in
- which case you should also send a report to your distribution and
- linux-block@vger.kernel.org.
+ created on demand, but scripts that manually create device nodes and
+ then call losetup might rely on this behavior.
config BLK_RQ_ALLOC_TIME
bool
diff --git a/block/bdev.c b/block/bdev.c
index c687726445660..a3632317c8aae 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -738,7 +738,7 @@ struct block_device *blkdev_get_no_open(dev_t dev)
inode = ilookup(blockdev_superblock, dev);
if (inode)
pr_warn_ratelimited(
-"block device autoloading is deprecated. It will be removed in Linux 5.19\n");
+"block device autoloading is deprecated and will be removed.\n");
}
if (!inode)
return NULL;
--
2.30.2
next reply other threads:[~2022-02-25 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 18:14 Christoph Hellwig [this message]
2022-02-25 18:37 ` [PATCH] block: default BLOCK_LEGACY_AUTOLOAD to y Chaitanya Kulkarni
2022-02-25 20:31 ` Jens Axboe
2022-02-25 21:23 ` Luis Chamberlain
2022-12-28 16:55 ` Anisse Astier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225181440.1351591-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox