* [PATCH] crytpo: fix crc64 testmgr digest byte order
@ 2022-03-22 14:21 kbusch
2022-03-22 14:31 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: kbusch @ 2022-03-22 14:21 UTC (permalink / raw)
To: linux-block, axboe; +Cc: ebiggers, Keith Busch
From: Keith Busch <kbusch@kernel.org>
The result is set in little endian, so the expected digest needs to
be consistent for big endian machines.
Fixes: commit f3813f4b287e4 ("crypto: add rocksoft 64b crc guard tag framework")
Reported-by: Vasily Gorbik <gor@linux.ibm.com>
Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
crypto/testmgr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/testmgr.h b/crypto/testmgr.h
index f1a22794c404..59919a636508 100644
--- a/crypto/testmgr.h
+++ b/crypto/testmgr.h
@@ -3686,11 +3686,11 @@ static const struct hash_testvec crc64_rocksoft_tv_template[] = {
{
.plaintext = zeroes,
.psize = 4096,
- .digest = (u8 *)(u64[]){ 0x6482d367eb22b64eull },
+ .digest = "\x4e\xb6\x22\xeb\x67\xd3\x82\x64",
}, {
.plaintext = ones,
.psize = 4096,
- .digest = (u8 *)(u64[]){ 0xc0ddba7302eca3acull },
+ .digest = "\xac\xa3\xec\x02\x73\xba\xdd\xc0",
}
};
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crytpo: fix crc64 testmgr digest byte order
2022-03-22 14:21 [PATCH] crytpo: fix crc64 testmgr digest byte order kbusch
@ 2022-03-22 14:31 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-03-22 14:31 UTC (permalink / raw)
To: kbusch, linux-block; +Cc: ebiggers
On Tue, 22 Mar 2022 08:21:07 -0600, kbusch@kernel.org wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The result is set in little endian, so the expected digest needs to
> be consistent for big endian machines.
>
>
Applied, thanks!
[1/1] crytpo: fix crc64 testmgr digest byte order
commit: c30cf83999ad58135fa01fbf9f2b15ce15b5cc4a
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-22 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-22 14:21 [PATCH] crytpo: fix crc64 testmgr digest byte order kbusch
2022-03-22 14:31 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox