From: Suwan Kim <suwan.kim027@gmail.com>
To: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, mgurtovoy@nvidia.com,
dongli.zhang@oracle.com, hch@infradead.org, elliott@hpe.com
Cc: virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, Suwan Kim <suwan.kim027@gmail.com>
Subject: [PATCH v6 0/2] virtio-blk: support polling I/O and mq_ops->queue_rqs()
Date: Thu, 7 Apr 2022 00:32:05 +0900 [thread overview]
Message-ID: <20220406153207.163134-1-suwan.kim027@gmail.com> (raw)
This patch serise adds support for polling I/O and mq_ops->queue_rqs()
to virtio-blk driver.
Changes
v5 -> v6
- patch1 : virtblk_poll
- Remove memset in init_vq()
- Fix space indent in init_vq()
- Replace if condition with positive check in virtblk_map_queues()
if (i == HCTX_TYPE_POLL)
blk_mq_map_queues(&set->map[i]);
else
blk_mq_virtio_map_queues(&set->map[i], vblk->vdev, 0);
- Add Reviewed-by tags
- patch2 : virtio_queue_rqs
- Add Reviewed-by tags
v4 -> v5
- patch1 : virtblk_poll
- Replace "req_done" with "found" in virtblk_poll()
- Split for loop into two distinct for loop in init_vq()
that sets callback function for each default/poll queues
- Replace "if (i == HCTX_TYPE_DEFAULT)" with "i != HCTX_TYPE_POLL"
in virtblk_map_queues()
- Replace "virtblk_unmap_data(req, vbr);" with
"virtblk_unmap_data(req, blk_mq_rq_to_pdu(req);"
in virtblk_complete_batch()
- patch2 : virtio_queue_rqs
- Instead of using vbr.sg_num field, use vbr->sg_table.nents.
So, remove sg_num field in struct virtblk_req
- Drop the unnecessary argument of virtblk_add_req() because it
doens't need "data_sg" and "have_data". It can be derived from "vbr"
argument.
- Add Reviewed-by tag from Stefan
v3 -> v4
- patch1 : virtblk_poll
- Add print the number of default/read/poll queues in init_vq()
- Add blk_mq_start_stopped_hw_queues() to virtblk_poll()
virtblk_poll()
...
if (req_done)
blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
...
- patch2 : virtio_queue_rqs
- Modify virtio_queue_rqs() to hold lock only once when it adds
requests to virtqueue just before virtqueue notify.
It will guarantee that virtio_queue_rqs() will not use
previous req again.
v2 -> v3
- Fix warning by kernel test robot
static int virtblk_poll()
...
if (!blk_mq_add_to_batch(req, iob, virtblk_result(vbr),
-> vbr->status,
v1 -> v2
- To receive the number of poll queues from user,
use module parameter instead of QEMU uapi change.
- Add the comment about virtblk_map_queues().
- Add support for mq_ops->queue_rqs() to implement submit side
batch.
Suwan Kim (2):
virtio-blk: support polling I/O
virtio-blk: support mq_ops->queue_rqs()
drivers/block/virtio_blk.c | 220 +++++++++++++++++++++++++++++++++----
1 file changed, 201 insertions(+), 19 deletions(-)
--
2.26.3
next reply other threads:[~2022-04-06 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 15:32 Suwan Kim [this message]
2022-04-06 15:32 ` [PATCH v6 1/2] virtio-blk: support polling I/O Suwan Kim
2022-04-07 19:32 ` Chaitanya Kulkarni
2022-04-06 15:32 ` [PATCH v6 2/2] virtio-blk: support mq_ops->queue_rqs() Suwan Kim
2022-04-07 19:33 ` Chaitanya Kulkarni
2022-04-07 19:36 ` [PATCH v6 0/2] virtio-blk: support polling I/O and mq_ops->queue_rqs() Chaitanya Kulkarni
2022-04-08 15:02 ` Suwan Kim
2022-04-11 23:47 ` Chaitanya Kulkarni
2022-05-18 13:20 ` Suwan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406153207.163134-1-suwan.kim027@gmail.com \
--to=suwan.kim027@gmail.com \
--cc=dongli.zhang@oracle.com \
--cc=elliott@hpe.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox