Linux block layer
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: Josef Bacik <josef@toxicpanda.com>
Subject: [PATCH v2 1/4] block: null_blk: Fix code style issues
Date: Wed, 20 Apr 2022 09:57:15 +0900	[thread overview]
Message-ID: <20220420005718.3780004-2-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20220420005718.3780004-1-damien.lemoal@opensource.wdc.com>

Fix message grammar and code style issues (brackets and indentation) in
null_init().

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/block/null_blk/main.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index c441a4972064..1aa4897685f6 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -2113,19 +2113,21 @@ static int __init null_init(void)
 	}
 
 	if (g_queue_mode == NULL_Q_RQ) {
-		pr_err("legacy IO path no longer available\n");
+		pr_err("legacy IO path is no longer available\n");
 		return -EINVAL;
 	}
+
 	if (g_queue_mode == NULL_Q_MQ && g_use_per_node_hctx) {
 		if (g_submit_queues != nr_online_nodes) {
 			pr_warn("submit_queues param is set to %u.\n",
-							nr_online_nodes);
+				nr_online_nodes);
 			g_submit_queues = nr_online_nodes;
 		}
-	} else if (g_submit_queues > nr_cpu_ids)
+	} else if (g_submit_queues > nr_cpu_ids) {
 		g_submit_queues = nr_cpu_ids;
-	else if (g_submit_queues <= 0)
+	} else if (g_submit_queues <= 0) {
 		g_submit_queues = 1;
+	}
 
 	if (g_queue_mode == NULL_Q_MQ && shared_tags) {
 		ret = null_init_tag_set(NULL, &tag_set);
-- 
2.35.1


  reply	other threads:[~2022-04-20  0:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  0:57 [PATCH v2 0/4] null_blk cleanup and device naming improvements Damien Le Moal
2022-04-20  0:57 ` Damien Le Moal [this message]
2022-04-20  3:51   ` [PATCH v2 1/4] block: null_blk: Fix code style issues Chaitanya Kulkarni
2022-04-20  7:56   ` Johannes Thumshirn
2022-04-20  0:57 ` [PATCH v2 2/4] block: null_blk: Cleanup device creation and deletion Damien Le Moal
2022-04-20  3:53   ` Chaitanya Kulkarni
2022-04-20  7:57   ` Johannes Thumshirn
2022-04-20  0:57 ` [PATCH v2 3/4] block: null_blk: Cleanup messages Damien Le Moal
2022-04-20  3:57   ` Chaitanya Kulkarni
2022-04-20  5:05     ` Damien Le Moal
2022-04-20  0:57 ` [PATCH v2 4/4] block: null_blk: Improve device creation with configfs Damien Le Moal
2022-04-20  7:58   ` Johannes Thumshirn
2022-05-03 20:03 ` [PATCH v2 0/4] null_blk cleanup and device naming improvements Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220420005718.3780004-2-damien.lemoal@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=axboe@kernel.dk \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox