From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v2 3/4] block: null_blk: Cleanup messages
Date: Wed, 20 Apr 2022 03:57:17 +0000 [thread overview]
Message-ID: <8413d847-fbdb-b209-1062-88439b24ccc4@nvidia.com> (raw)
In-Reply-To: <20220420005718.3780004-4-damien.lemoal@opensource.wdc.com>
On 4/19/22 17:57, Damien Le Moal wrote:
> Use the pr_fmt() macro to prefix all null_blk pr_xxx() messages with
> "null_blk:" to clarify which module is printing the messages. Also add
> a pr_info() message in null_add_dev() to print the name of a newly
> created disk.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
why not [1] to keep #define pr_fmt at one place in header file
instead of duplicating it in zoned.c main.c ?
irrespective of that, looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
[1]
diff --git a/drivers/block/null_blk/null_blk.h
b/drivers/block/null_blk/null_blk.h
index 78eb56b0ca55..450849fb3038 100644
--- a/drivers/block/null_blk/null_blk.h
+++ b/drivers/block/null_blk/null_blk.h
@@ -167,4 +167,8 @@ static inline size_t null_zone_valid_read_len(struct
nullb *nullb,
}
#define null_report_zones NULL
#endif /* CONFIG_BLK_DEV_ZONED */
+
+#undef pr_fmt
+#define pr_fmt(fmt) "null_blk: " fmt
+
#endif /* __NULL_BLK_H */
next prev parent reply other threads:[~2022-04-20 3:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 0:57 [PATCH v2 0/4] null_blk cleanup and device naming improvements Damien Le Moal
2022-04-20 0:57 ` [PATCH v2 1/4] block: null_blk: Fix code style issues Damien Le Moal
2022-04-20 3:51 ` Chaitanya Kulkarni
2022-04-20 7:56 ` Johannes Thumshirn
2022-04-20 0:57 ` [PATCH v2 2/4] block: null_blk: Cleanup device creation and deletion Damien Le Moal
2022-04-20 3:53 ` Chaitanya Kulkarni
2022-04-20 7:57 ` Johannes Thumshirn
2022-04-20 0:57 ` [PATCH v2 3/4] block: null_blk: Cleanup messages Damien Le Moal
2022-04-20 3:57 ` Chaitanya Kulkarni [this message]
2022-04-20 5:05 ` Damien Le Moal
2022-04-20 0:57 ` [PATCH v2 4/4] block: null_blk: Improve device creation with configfs Damien Le Moal
2022-04-20 7:58 ` Johannes Thumshirn
2022-05-03 20:03 ` [PATCH v2 0/4] null_blk cleanup and device naming improvements Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8413d847-fbdb-b209-1062-88439b24ccc4@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox