Linux block layer
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Jan Kara <jack@suse.cz>, "osandov@fb.com" <osandov@fb.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blktests: Ignore errors from wait(1)
Date: Tue, 14 Jun 2022 15:18:03 +0200	[thread overview]
Message-ID: <20220614131803.hwoykpwzfh6pxmda@quack3.lan> (raw)
In-Reply-To: <20220614070454.5tcyunt53nqf3y7q@shindev>

On Tue 14-06-22 07:04:54, Shinichiro Kawasaki wrote:
> On Jun 13, 2022 / 17:17, Jan Kara wrote:
> > Multiple blktests use wait(1) to wait for background tasks. However in
> > some cases tasks can exit before wait(1) is called and in that case
> > wait(1) complains which breaks expected output. Make sure we ignore
> > output from wait(1) to avoid this breakage.
> 
> Hi Jan, thanks for the patch.
> 
> May I know how to create the wait(1) complaint message? I added sleep
> command before the waits to ensure the background tasks completed, but
> was not able to see message by wait on my test system. I suspect it may
> depend on bash version.

Yes, I suspect it depends on the shell as well (because otherwise I expect
people would hit this much earlier than me :). The bash I have is
"4.4.23(1)-release" - the one in openSUSE 15.3 and it shows the error
pretty reliably...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2022-06-14 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 15:17 [PATCH] blktests: Ignore errors from wait(1) Jan Kara
2022-06-13 22:48 ` Chaitanya Kulkarni
2022-06-14 13:15   ` Jan Kara
2022-06-15 11:30     ` Shinichiro Kawasaki
2022-06-14  7:04 ` Shinichiro Kawasaki
2022-06-14 13:18   ` Jan Kara [this message]
2022-06-15 11:50     ` Shinichiro Kawasaki
2022-06-15 16:56       ` Jan Kara
2022-06-16  4:16         ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614131803.hwoykpwzfh6pxmda@quack3.lan \
    --to=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox