Re: [PATCH] blktests: Ignore errors from wait(1)

[Jan Kara <jack@suse.cz>]

On Wed 15-06-22 11:50:14, Shinichiro Kawasaki wrote:
> On Jun 14, 2022 / 15:18, Jan Kara wrote:
> > On Tue 14-06-22 07:04:54, Shinichiro Kawasaki wrote:
> 
> [...]
> 
> > Yes, I suspect it depends on the shell as well (because otherwise I expect
> > people would hit this much earlier than me :). The bash I have is
> > "4.4.23(1)-release" - the one in openSUSE 15.3 and it shows the error
> > pretty reliably...
> 
> I guess the problematic wait command output is job exit status report. To
> confirm my guess, could your share example of the wait command output?
> 
> Based on my guess, I checked difference between bash 4.4 and my bash 5.1, but I
> did not find notable bash code change about job exit status report. Hmm.
> 
> Your patch covers several waits in the block group. I suspect other waits in
> other groups may have same risk. Instead of your patch, could you try the patch
> below on your system? If it works, all waits in all groups can be addressed.

Ah, indeed. This patch fixes the problem for me as well. Thanks for looking
into this!

								Honza

> 
> diff --git a/check b/check
> index 7037d88..ac24afa 100755
> --- a/check
> +++ b/check
> @@ -440,6 +440,10 @@ _run_test() {
>  	RUN_FOR_ZONED=0
>  	FALLBACK_DEVICE=0
>  
> +	# Ensure job control monitor mode is off in this sub-shell to suppress
> +	# job status output.
> +	set +m
> +
>  	# shellcheck disable=SC1090
>  	. "tests/${TEST_NAME}"
>  
> 
> 
> -- 
> Shin'ichiro Kawasaki
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR