Linux block layer
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: linux-block@vger.kernel.org
Cc: shinichiro.kawasaki@wdc.com
Subject: [PATCH blktests] block/008: fix cpu online restore
Date: Mon,  4 Jul 2022 02:09:57 +0800	[thread overview]
Message-ID: <20220703180956.2922025-1-yi.zhang@redhat.com> (raw)

The offline cpus cannot be restored during _cleanup when only _offline_cpu
executed, fix it by reset RESTORE_CPUS_ONLINE=1 during test.

Fixes: bd6b882 ("block/008: check CPU offline failure due to many IRQs")
Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 tests/block/008 | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/block/008 b/tests/block/008
index 75aae65..f61f33a 100755
--- a/tests/block/008
+++ b/tests/block/008
@@ -91,6 +91,11 @@ test_device() {
 		fi
 	done
 
+	# The RESTORE_CPUS_ONLINE setting was ignored with previous
+	# err=$(_offline_cpu "${online_cpus[$idx]}" when only _offline_cpu
+	# executed, reset it here then the offline cpus can be retored
+	# shellcheck disable=SC2034
+	RESTORE_CPUS_ONLINE=1
 	FIO_PERF_FIELDS=("read iops")
 	_fio_perf_report
 
-- 
2.34.1


             reply	other threads:[~2022-07-03 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-03 18:09 Yi Zhang [this message]
2022-07-04  5:20 ` [PATCH blktests] block/008: fix cpu online restore Shinichiro Kawasaki
2022-07-04  6:47   ` Yi Zhang
2022-07-04 11:46     ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220703180956.2922025-1-yi.zhang@redhat.com \
    --to=yi.zhang@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox