Re: [PATCH blktests] block/008: fix cpu online restore

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Jul 04, 2022 / 14:47, Yi Zhang wrote:
> On Mon, Jul 4, 2022 at 1:20 PM Shinichiro Kawasaki
> <shinichiro.kawasaki@wdc.com> wrote:
> >
> > On Jul 04, 2022 / 02:09, Yi Zhang wrote:
> > > The offline cpus cannot be restored during _cleanup when only _offline_cpu
> > > executed, fix it by reset RESTORE_CPUS_ONLINE=1 during test.
> > >
> > > Fixes: bd6b882 ("block/008: check CPU offline failure due to many IRQs")
> > > Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> >
> > Hello Yi, thank you for catching this. The commit bd6b882 put the _offline_cpu
> > call into a sub-shell, then RESTORE_CPUS_ONLINE reset in the function no longer
> > affects _cleanup function. When I made the commit, I overlooked that point.
> >
> > Your change should fix the issue but it makes the RESTORE_CPUS_ONLINE=1 in
> > _offline_cpu meaningless. Instead, I suggest following patch. Could you confirm
> > it fixes the issue in your environment?
> 
> Yeah, your change works well, feel free to add
> Tested-by: Yi Zhang <yi.zhang@redhat.com>

Thanks! I've posted the change with your tag as a formal patch.

-- 
Shin'ichiro Kawasaki