From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 2/2] ublk_drv: make sure that correct flags(features) returned to userspace
Date: Fri, 22 Jul 2022 11:53:19 +0200 [thread overview]
Message-ID: <20220722095319.GA13942@lst.de> (raw)
In-Reply-To: <20220722084516.624457-3-ming.lei@redhat.com>
On Fri, Jul 22, 2022 at 04:45:16PM +0800, Ming Lei wrote:
> /* We are not ready to support zero copy */
> + ub->dev_info.flags &= ~UBLK_F_SUPPORT_ZERO_COPY;
Nit: I'd move this below the clearing of UBLK_F_ALL. Not because it
makes much of a differece, but because it flows more logical.
> +/* All UBLK_F_* have to be included into UBLK_F_ALL */
> +#define UBLK_F_ALL (UBLK_F_SUPPORT_ZERO_COPY | UBLK_F_URING_CMD_COMP_IN_TASK)
And this should not be in the uapi header but only kernel internal.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-07-22 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:45 [PATCH V3 0/2] ublk_drv: make sure that correct flags(features) returned to userspace Ming Lei
2022-07-22 8:45 ` [PATCH V3 1/2] ublk_drv: fix error handling of ublk_add_dev Ming Lei
2022-07-22 8:57 ` Ziyang Zhang
2022-07-22 8:45 ` [PATCH V3 2/2] ublk_drv: make sure that correct flags(features) returned to userspace Ming Lei
2022-07-22 9:53 ` Christoph Hellwig [this message]
2022-07-22 10:03 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722095319.GA13942@lst.de \
--to=hch@lst.de \
--cc=ZiyangZhang@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox