From: Pankaj Raghav <p.raghav@samsung.com>
To: axboe@kernel.dk, hch@lst.de
Cc: gost.dev@samsung.com, linux-block@vger.kernel.org,
damien.lemoal@opensource.wdc.com,
Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH v3 2/2] block: use blk_mq_plug() wrapper consistently in the block layer
Date: Thu, 29 Sep 2022 09:47:45 +0200 [thread overview]
Message-ID: <20220929074745.103073-3-p.raghav@samsung.com> (raw)
In-Reply-To: <20220929074745.103073-1-p.raghav@samsung.com>
Use blk_mq_plug() wrapper to get the plug instead of directly accessing
it in the block layer.
Either of the changes should not have led to a bug in zoned devices:
- blk_execute_rq_nowait:
Only passthrough requests can use this function, and plugging can be
performed on those requests in zoned devices. So no issues directly
accessing the plug.
- blk_flush_plug in bio_poll:
As we don't plug the requests that require a zone lock in the first
place, flushing should not have any impact. So no issues directly
accessing the plug.
This is just a cleanup patch to use this wrapper to get the plug
consistently across the block layer.
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
block/blk-core.c | 2 +-
block/blk-mq.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 203be672da52..d0e97de216db 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -850,7 +850,7 @@ int bio_poll(struct bio *bio, struct io_comp_batch *iob, unsigned int flags)
!test_bit(QUEUE_FLAG_POLL, &q->queue_flags))
return 0;
- blk_flush_plug(current->plug, false);
+ blk_flush_plug(blk_mq_plug(bio), false);
if (bio_queue_enter(bio))
return 0;
diff --git a/block/blk-mq.c b/block/blk-mq.c
index c11949d66163..5bf245c4bf0a 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1209,12 +1209,14 @@ static void blk_add_rq_to_plug(struct blk_plug *plug, struct request *rq)
*/
void blk_execute_rq_nowait(struct request *rq, bool at_head)
{
+ struct blk_plug *plug = blk_mq_plug(rq->bio);
+
WARN_ON(irqs_disabled());
WARN_ON(!blk_rq_is_passthrough(rq));
blk_account_io_start(rq);
- if (current->plug)
- blk_add_rq_to_plug(current->plug, rq);
+ if (plug)
+ blk_add_rq_to_plug(plug, rq);
else
blk_mq_sched_insert_request(rq, at_head, true, false);
}
--
2.25.1
next prev parent reply other threads:[~2022-09-29 7:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220929074747eucas1p1821a5b79ad24cb559b7b6ec324239e9e@eucas1p1.samsung.com>
2022-09-29 7:47 ` [PATCH v3 0/2] plugging cleanup v3 Pankaj Raghav
2022-09-29 7:47 ` [PATCH v3 1/2] block: adapt blk_mq_plug() to not plug for writes that require a zone lock Pankaj Raghav
2022-09-29 8:14 ` Damien Le Moal
2022-09-29 8:34 ` Johannes Thumshirn
2022-09-29 7:47 ` Pankaj Raghav [this message]
2022-09-29 8:15 ` [PATCH v3 2/2] block: use blk_mq_plug() wrapper consistently in the block layer Damien Le Moal
2022-09-29 8:35 ` Johannes Thumshirn
2022-09-29 13:24 ` Jens Axboe
2022-09-29 13:41 ` Pankaj Raghav
2022-09-29 13:45 ` Jens Axboe
2022-09-29 13:48 ` Pankaj Raghav
2022-09-29 13:46 ` (subset) [PATCH v3 0/2] plugging cleanup v3 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929074745.103073-3-p.raghav@samsung.com \
--to=p.raghav@samsung.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox