Re: [PATCH v3 2/2] block: use blk_mq_plug() wrapper consistently in the block layer

[Jens Axboe <axboe@kernel.dk>]

On 9/29/22 1:47 AM, Pankaj Raghav wrote:
> Use blk_mq_plug() wrapper to get the plug instead of directly accessing
> it in the block layer.
> 
> Either of the changes should not have led to a bug in zoned devices:
> 
> - blk_execute_rq_nowait:
>   Only passthrough requests can use this function, and plugging can be
>   performed on those requests in zoned devices. So no issues directly
>   accessing the plug.
> 
> - blk_flush_plug in bio_poll:
>   As we don't plug the requests that require a zone lock in the first
>   place, flushing should not have any impact. So no issues directly
>   accessing the plug.
> 
> This is just a cleanup patch to use this wrapper to get the plug
> consistently across the block layer.

While I did suggest to make this consistent and in principle it's
the right thing to do, it also irks me to add extra checks to paths
where we know that it's just extra pointless code. Maybe we can
just comment these two spots? Basically each of the sections above
could just go into the appropriate file.

-- 
Jens Axboe