public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org, linux-block@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Cc: "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
	Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: [PATCH v6 7/7] ata: libata: Enable fua support by default
Date: Tue,  8 Nov 2022 14:55:44 +0900	[thread overview]
Message-ID: <20221108055544.1481583-8-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20221108055544.1481583-1-damien.lemoal@opensource.wdc.com>

Change the default value of the fua module parameter to 1 to enable fua
support by default for all devices supporting it.

FUA support can be disabled for individual drives using the
force=[ID]nofua libata module argument.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 drivers/ata/libata-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 97ade977b830..2967671131d2 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -127,9 +127,9 @@ int atapi_passthru16 = 1;
 module_param(atapi_passthru16, int, 0444);
 MODULE_PARM_DESC(atapi_passthru16, "Enable ATA_16 passthru for ATAPI devices (0=off, 1=on [default])");
 
-int libata_fua = 0;
+int libata_fua = 1;
 module_param_named(fua, libata_fua, int, 0444);
-MODULE_PARM_DESC(fua, "FUA support (0=off [default], 1=on)");
+MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on [default])");
 
 static int ata_ignore_hpa;
 module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
-- 
2.38.1


  parent reply	other threads:[~2022-11-08  5:56 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  5:55 [PATCH v6 0/7] Improve libata support for FUA Damien Le Moal
2022-11-08  5:55 ` [PATCH v6 1/7] block: add a sanity check for non-write flush/fua bios Damien Le Moal
2022-11-08  7:37   ` Johannes Thumshirn
2022-12-30  7:21   ` Niklas Cassel
2022-12-30 11:54   ` Niklas Cassel
2022-12-30 12:28     ` Damien Le Moal
2023-01-02 17:35   ` Jens Axboe
2022-11-08  5:55 ` [PATCH v6 2/7] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-11-08  7:38   ` Johannes Thumshirn
2022-12-30  7:38   ` Niklas Cassel
2022-11-08  5:55 ` [PATCH v6 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-11-08  7:39   ` Johannes Thumshirn
2022-12-30  7:42   ` Niklas Cassel
2022-11-08  5:55 ` [PATCH v6 4/7] ata: libata: cleanup fua support detection Damien Le Moal
2022-11-08  7:42   ` Johannes Thumshirn
2022-12-30  8:01   ` Niklas Cassel
2022-11-08  5:55 ` [PATCH v6 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-11-08  6:21   ` Christoph Hellwig
2022-11-08  7:44   ` Johannes Thumshirn
2022-12-30  8:57   ` Niklas Cassel
2022-11-08  5:55 ` [PATCH v6 6/7] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2022-11-08  7:45   ` Johannes Thumshirn
2022-12-30  8:58   ` Niklas Cassel
2022-11-08  5:55 ` Damien Le Moal [this message]
2022-11-08  7:45   ` [PATCH v6 7/7] ata: libata: Enable fua support by default Johannes Thumshirn
2022-12-30 10:54   ` Niklas Cassel
2022-12-30 11:21     ` Damien Le Moal
2022-12-30 12:41       ` Niklas Cassel
2022-12-30 12:55         ` Damien Le Moal
2022-12-30 14:47   ` Niklas Cassel
2022-12-29 17:55 ` [PATCH v6 0/7] Improve libata support for FUA Maciej S. Szmigiero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221108055544.1481583-8-damien.lemoal@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox