From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v6 6/7] ata: libata: blacklist FUA support for known buggy drives
Date: Fri, 30 Dec 2022 08:58:27 +0000 [thread overview]
Message-ID: <Y66oMQT7UO/NLm50@x1-carbon> (raw)
In-Reply-To: <20221108055544.1481583-7-damien.lemoal@opensource.wdc.com>
On Tue, Nov 08, 2022 at 02:55:43PM +0900, Damien Le Moal wrote:
> Thread [1] reported back in 2012 problems with enabling FUA for 3
> different drives. Add these drives to ata_device_blacklist[] to mark
> them with the ATA_HORKAGE_NO_FUA flag. To be conservative and avoid
> problems on old systems, the model number for the three new entries
> are defined as to widely match all drives in the same product line.
>
> [1]: https://lore.kernel.org/lkml/CA+6av4=uxu_q5U_46HtpUt=FSgbh3pZuAEY54J5_xK=MKWq-YQ@mail.gmail.com/
>
> Suggested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/ata/libata-core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 2b66fe529d81..97ade977b830 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4133,6 +4133,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>
> /* Buggy FUA */
> { "Maxtor", "BANC1G10", ATA_HORKAGE_NO_FUA },
> + { "WDC*WD2500J*", NULL, ATA_HORKAGE_NO_FUA },
> + { "OCZ-VERTEX*", NULL, ATA_HORKAGE_NO_FUA },
> + { "INTEL*SSDSC2CT*", NULL, ATA_HORKAGE_NO_FUA },
>
> /* End Marker */
> { }
> --
> 2.38.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2022-12-30 8:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 5:55 [PATCH v6 0/7] Improve libata support for FUA Damien Le Moal
2022-11-08 5:55 ` [PATCH v6 1/7] block: add a sanity check for non-write flush/fua bios Damien Le Moal
2022-11-08 7:37 ` Johannes Thumshirn
2022-12-30 7:21 ` Niklas Cassel
2022-12-30 11:54 ` Niklas Cassel
2022-12-30 12:28 ` Damien Le Moal
2023-01-02 17:35 ` Jens Axboe
2022-11-08 5:55 ` [PATCH v6 2/7] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-11-08 7:38 ` Johannes Thumshirn
2022-12-30 7:38 ` Niklas Cassel
2022-11-08 5:55 ` [PATCH v6 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-11-08 7:39 ` Johannes Thumshirn
2022-12-30 7:42 ` Niklas Cassel
2022-11-08 5:55 ` [PATCH v6 4/7] ata: libata: cleanup fua support detection Damien Le Moal
2022-11-08 7:42 ` Johannes Thumshirn
2022-12-30 8:01 ` Niklas Cassel
2022-11-08 5:55 ` [PATCH v6 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-11-08 6:21 ` Christoph Hellwig
2022-11-08 7:44 ` Johannes Thumshirn
2022-12-30 8:57 ` Niklas Cassel
2022-11-08 5:55 ` [PATCH v6 6/7] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2022-11-08 7:45 ` Johannes Thumshirn
2022-12-30 8:58 ` Niklas Cassel [this message]
2022-11-08 5:55 ` [PATCH v6 7/7] ata: libata: Enable fua support by default Damien Le Moal
2022-11-08 7:45 ` Johannes Thumshirn
2022-12-30 10:54 ` Niklas Cassel
2022-12-30 11:21 ` Damien Le Moal
2022-12-30 12:41 ` Niklas Cassel
2022-12-30 12:55 ` Damien Le Moal
2022-12-30 14:47 ` Niklas Cassel
2022-12-29 17:55 ` [PATCH v6 0/7] Improve libata support for FUA Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y66oMQT7UO/NLm50@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox