From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: paolo.valente@linaro.org, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
jack@suse.cz, hch@lst.de, damien.lemoal@wdc.com
Subject: Re: [PATCH RESEND v2 05/10] block, bfq: remove unnecessary dereference to get async_bfqq
Date: Mon, 2 Jan 2023 16:34:58 +0100 [thread overview]
Message-ID: <20230102153458.zg3ku5styjcz2gf3@quack3> (raw)
In-Reply-To: <20221222191641.1643117-6-shikemeng@huaweicloud.com>
On Fri 23-12-22 03:16:36, Kemeng Shi wrote:
> The async_bfqq is assigned with bfqq->bic->bfqq[0], use it directly.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Yeah, that is a more logical choice. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index c3c4c83ee95f..ebcafe3c4c3b 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -4835,7 +4835,7 @@ static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd)
> icq_to_bic(async_bfqq->next_rq->elv.icq) == bfqq->bic &&
> bfq_serv_to_charge(async_bfqq->next_rq, async_bfqq) <=
> bfq_bfqq_budget_left(async_bfqq))
> - bfqq = bfqq->bic->bfqq[0];
> + bfqq = async_bfqq;
> else if (bfqq->waker_bfqq &&
> bfq_bfqq_busy(bfqq->waker_bfqq) &&
> bfqq->waker_bfqq->next_rq &&
> --
> 2.30.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-01-02 15:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 19:16 [PATCH RESEND v2 00/10] A few bugfix and cleancode patch for bfq Kemeng Shi
2022-12-22 19:16 ` [PATCH RESEND v2 01/10] block, bfq: correctly raise inject limit in bfq_choose_bfqq_for_injection Kemeng Shi
2023-01-02 15:13 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 02/10] block, bfq: remove unsed parameter reason in bfq_bfqq_is_slow Kemeng Shi
2023-01-02 15:14 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 03/10] block, bfq: initialize bfqq->decrease_time_jif correctly Kemeng Shi
2023-01-02 15:30 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 04/10] block, bfq: use helper macro RQ_BFQQ to get bfqq of request Kemeng Shi
2023-01-02 15:31 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 05/10] block, bfq: remove unnecessary dereference to get async_bfqq Kemeng Shi
2023-01-02 15:34 ` Jan Kara [this message]
2022-12-22 19:16 ` [PATCH RESEND v2 06/10] block, bfq: remove redundant bfqd->rq_in_driver > 0 check in bfq_add_request Kemeng Shi
2023-01-02 15:54 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 07/10] block, bfq: remove redundant check in bfq_put_cooperator Kemeng Shi
2023-01-02 15:57 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 08/10] block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq Kemeng Shi
2023-01-02 15:59 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 09/10] block, bfq: remove unused bfq_wr_max_time in struct bfq_data Kemeng Shi
2023-01-02 16:00 ` Jan Kara
2022-12-22 19:16 ` [PATCH RESEND v2 10/10] block, bfq: remove check of bfq_wr_max_softrt_rate which is always greater than 0 Kemeng Shi
2023-01-02 16:05 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102153458.zg3ku5styjcz2gf3@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox