* [PATCH rcu 07/27] block: Remove "select SRCU"
[not found] <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1>
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 0:43 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Jens Axboe,
linux-block
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
---
block/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/Kconfig b/block/Kconfig
index 444c5ab3b67e2..5d9d9c84d5165 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -6,7 +6,6 @@ menuconfig BLOCK
bool "Enable the block layer" if EXPERT
default y
select SBITMAP
- select SRCU
help
Provide block layer support for the kernel.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 07/27] block: Remove "select SRCU" Paul E. McKenney
@ 2023-01-05 0:43 ` Jens Axboe
2023-01-05 8:05 ` Heiko Carstens
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2023-01-05 0:43 UTC (permalink / raw)
To: Paul E. McKenney, rcu; +Cc: linux-kernel, kernel-team, rostedt, linux-block
On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
I'm assuming something earlier made this true (only CC'ed on this patch,
not the cover letter or interesting btis...), then:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 0:43 ` Jens Axboe
@ 2023-01-05 8:05 ` Heiko Carstens
2023-01-05 15:33 ` Paul E. McKenney
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Carstens @ 2023-01-05 8:05 UTC (permalink / raw)
To: Jens Axboe
Cc: Paul E. McKenney, rcu, linux-kernel, kernel-team, rostedt,
linux-block
On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
> On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
>
> I'm assuming something earlier made this true (only CC'ed on this patch,
> not the cover letter or interesting btis...), then:
I was wondering the same. But it is already unconditionally enabled
since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 8:05 ` Heiko Carstens
@ 2023-01-05 15:33 ` Paul E. McKenney
2023-01-05 15:36 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:33 UTC (permalink / raw)
To: Heiko Carstens
Cc: Jens Axboe, rcu, linux-kernel, kernel-team, rostedt, linux-block
On Thu, Jan 05, 2023 at 09:05:47AM +0100, Heiko Carstens wrote:
> On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
> > On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> > > Now that the SRCU Kconfig option is unconditionally selected, there is
> > > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > > Kconfig statements.
> >
> > I'm assuming something earlier made this true (only CC'ed on this patch,
> > not the cover letter or interesting btis...), then:
>
> I was wondering the same. But it is already unconditionally enabled
> since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
Ah, apologies for the terseness!
I took the coward's way out by making CONFIG_SRCU unconditional during
the last merge window and removing all references during this merge
window. ;-)
Thanx, Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 15:33 ` Paul E. McKenney
@ 2023-01-05 15:36 ` Jens Axboe
2023-01-05 15:48 ` Paul E. McKenney
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2023-01-05 15:36 UTC (permalink / raw)
To: paulmck, Heiko Carstens
Cc: rcu, linux-kernel, kernel-team, rostedt, linux-block
On 1/5/23 8:33 AM, Paul E. McKenney wrote:
> On Thu, Jan 05, 2023 at 09:05:47AM +0100, Heiko Carstens wrote:
>> On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
>>> On 1/4/23 5:37 PM, Paul E. McKenney wrote:
>>>> Now that the SRCU Kconfig option is unconditionally selected, there is
>>>> no longer any point in selecting it. Therefore, remove the "select SRCU"
>>>> Kconfig statements.
>>>
>>> I'm assuming something earlier made this true (only CC'ed on this patch,
>>> not the cover letter or interesting btis...), then:
>>
>> I was wondering the same. But it is already unconditionally enabled
>> since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
>
> Ah, apologies for the terseness!
>
> I took the coward's way out by making CONFIG_SRCU unconditional during
> the last merge window and removing all references during this merge
> window. ;-)
Are you intending for maintainers to pick up these patches, or are you
collecting acks for sending the series separately? That part is also
not clear :-)
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 15:36 ` Jens Axboe
@ 2023-01-05 15:48 ` Paul E. McKenney
0 siblings, 0 replies; 6+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:48 UTC (permalink / raw)
To: Jens Axboe
Cc: Heiko Carstens, rcu, linux-kernel, kernel-team, rostedt,
linux-block
On Thu, Jan 05, 2023 at 08:36:43AM -0700, Jens Axboe wrote:
> On 1/5/23 8:33 AM, Paul E. McKenney wrote:
> > On Thu, Jan 05, 2023 at 09:05:47AM +0100, Heiko Carstens wrote:
> >> On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
> >>> On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> >>>> Now that the SRCU Kconfig option is unconditionally selected, there is
> >>>> no longer any point in selecting it. Therefore, remove the "select SRCU"
> >>>> Kconfig statements.
> >>>
> >>> I'm assuming something earlier made this true (only CC'ed on this patch,
> >>> not the cover letter or interesting btis...), then:
> >>
> >> I was wondering the same. But it is already unconditionally enabled
> >> since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
> >
> > Ah, apologies for the terseness!
> >
> > I took the coward's way out by making CONFIG_SRCU unconditional during
> > the last merge window and removing all references during this merge
> > window. ;-)
>
> Are you intending for maintainers to pick up these patches, or are you
> collecting acks for sending the series separately? That part is also
> not clear :-)
Fair point!
Maintainer's choice. By default, I collect acks and send it. But if
(for example) this change is in a high-traffic area, the maintainer
might want to take it, in which case I drop it from my tree.
Either way works for me, as long as you let me know. ;-)
Thanx, Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-05 15:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1>
2023-01-05 0:37 ` [PATCH rcu 07/27] block: Remove "select SRCU" Paul E. McKenney
2023-01-05 0:43 ` Jens Axboe
2023-01-05 8:05 ` Heiko Carstens
2023-01-05 15:33 ` Paul E. McKenney
2023-01-05 15:36 ` Jens Axboe
2023-01-05 15:48 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox