* [PATCH] s390/dcssblk:: don't call bio_split_to_limits
@ 2023-01-23 7:53 Christoph Hellwig
2023-01-24 13:41 ` Alexander Gordeev
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Christoph Hellwig @ 2023-01-23 7:53 UTC (permalink / raw)
To: hca, gor, agordeev; +Cc: linux-s390, linux-block
s390 iterates over the bio using bio_for_each_segment and doesn't need
any bio splitting.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/s390/block/dcssblk.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
index c0f85ffb2b62de..c09f2e053bf863 100644
--- a/drivers/s390/block/dcssblk.c
+++ b/drivers/s390/block/dcssblk.c
@@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)
unsigned long source_addr;
unsigned long bytes_done;
- bio = bio_split_to_limits(bio);
- if (!bio)
- return;
-
bytes_done = 0;
dev_info = bio->bi_bdev->bd_disk->private_data;
if (dev_info == NULL)
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] s390/dcssblk:: don't call bio_split_to_limits
2023-01-23 7:53 [PATCH] s390/dcssblk:: don't call bio_split_to_limits Christoph Hellwig
@ 2023-01-24 13:41 ` Alexander Gordeev
2023-01-24 13:45 ` Christoph Hellwig
2023-01-24 18:22 ` Alexander Gordeev
2023-01-24 18:27 ` Jens Axboe
2 siblings, 1 reply; 5+ messages in thread
From: Alexander Gordeev @ 2023-01-24 13:41 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: hca, gor, linux-s390, linux-block, Gerald Schaefer
On Mon, Jan 23, 2023 at 08:53:56AM +0100, Christoph Hellwig wrote:
Hi Christoph,
> s390 iterates over the bio using bio_for_each_segment and doesn't need
> any bio splitting.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/s390/block/dcssblk.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> index c0f85ffb2b62de..c09f2e053bf863 100644
> --- a/drivers/s390/block/dcssblk.c
> +++ b/drivers/s390/block/dcssblk.c
> @@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)
> unsigned long source_addr;
> unsigned long bytes_done;
>
> - bio = bio_split_to_limits(bio);
> - if (!bio)
> - return;
> -
> bytes_done = 0;
> dev_info = bio->bi_bdev->bd_disk->private_data;
> if (dev_info == NULL)
If my understanding is correct that this change was as good as
early as commit 54efd50bfd87 ("block: make generic_make_request
handle arbitrarily sized bios") took place and simply fell into
the second category?
...
Some make_request_fn() callbacks were simple enough to audit and verify
they don't need blk_queue_split() calls. The skipped ones are:
...
Some others are almost certainly safe to remove now, but will be left
for future patches.
...
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] s390/dcssblk:: don't call bio_split_to_limits
2023-01-24 13:41 ` Alexander Gordeev
@ 2023-01-24 13:45 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2023-01-24 13:45 UTC (permalink / raw)
To: Alexander Gordeev
Cc: Christoph Hellwig, hca, gor, linux-s390, linux-block,
Gerald Schaefer
On Tue, Jan 24, 2023 at 02:41:34PM +0100, Alexander Gordeev wrote:
> If my understanding is correct that this change was as good as
> early as commit 54efd50bfd87 ("block: make generic_make_request
> handle arbitrarily sized bios") took place and simply fell into
> the second category?
Yes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] s390/dcssblk:: don't call bio_split_to_limits
2023-01-23 7:53 [PATCH] s390/dcssblk:: don't call bio_split_to_limits Christoph Hellwig
2023-01-24 13:41 ` Alexander Gordeev
@ 2023-01-24 18:22 ` Alexander Gordeev
2023-01-24 18:27 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Alexander Gordeev @ 2023-01-24 18:22 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: hca, gor, linux-s390, linux-block, Gerald Schaefer
On Mon, Jan 23, 2023 at 08:53:56AM +0100, Christoph Hellwig wrote:
> s390 iterates over the bio using bio_for_each_segment and doesn't need
> any bio splitting.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/s390/block/dcssblk.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c
> index c0f85ffb2b62de..c09f2e053bf863 100644
> --- a/drivers/s390/block/dcssblk.c
> +++ b/drivers/s390/block/dcssblk.c
> @@ -864,10 +864,6 @@ dcssblk_submit_bio(struct bio *bio)
> unsigned long source_addr;
> unsigned long bytes_done;
>
> - bio = bio_split_to_limits(bio);
> - if (!bio)
> - return;
> -
> bytes_done = 0;
> dev_info = bio->bi_bdev->bd_disk->private_data;
> if (dev_info == NULL)
Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] s390/dcssblk:: don't call bio_split_to_limits
2023-01-23 7:53 [PATCH] s390/dcssblk:: don't call bio_split_to_limits Christoph Hellwig
2023-01-24 13:41 ` Alexander Gordeev
2023-01-24 18:22 ` Alexander Gordeev
@ 2023-01-24 18:27 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2023-01-24 18:27 UTC (permalink / raw)
To: hca, gor, agordeev, Christoph Hellwig; +Cc: linux-s390, linux-block
On Mon, 23 Jan 2023 08:53:56 +0100, Christoph Hellwig wrote:
> s390 iterates over the bio using bio_for_each_segment and doesn't need
> any bio splitting.
>
>
Applied, thanks!
[1/1] s390/dcssblk:: don't call bio_split_to_limits
commit: a2aea8f56f9ee995aeabeb633b708024a3be5281
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-24 18:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-23 7:53 [PATCH] s390/dcssblk:: don't call bio_split_to_limits Christoph Hellwig
2023-01-24 13:41 ` Alexander Gordeev
2023-01-24 13:45 ` Christoph Hellwig
2023-01-24 18:22 ` Alexander Gordeev
2023-01-24 18:27 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox