Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 03/11] md-bitmap: use %pD to print the file name in md_bitmap_file_kick
Date: Thu, 15 Jun 2023 08:48:32 +0200	[thread overview]
Message-ID: <20230615064840.629492-4-hch@lst.de> (raw)
In-Reply-To: <20230615064840.629492-1-hch@lst.de>

Don't bother allocating an extra buffer in the I/O failure handler and
instead use the printk built-in format to print the last 4 path name
components.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/md-bitmap.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index 0b2d8933cbc75e..e4b466522d4e74 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -870,21 +870,13 @@ static void md_bitmap_file_unmap(struct bitmap_storage *store)
  */
 static void md_bitmap_file_kick(struct bitmap *bitmap)
 {
-	char *path, *ptr = NULL;
-
 	if (!test_and_set_bit(BITMAP_STALE, &bitmap->flags)) {
 		md_bitmap_update_sb(bitmap);
 
 		if (bitmap->storage.file) {
-			path = kmalloc(PAGE_SIZE, GFP_KERNEL);
-			if (path)
-				ptr = file_path(bitmap->storage.file,
-					     path, PAGE_SIZE);
-
-			pr_warn("%s: kicking failed bitmap file %s from array!\n",
-				bmname(bitmap), IS_ERR(ptr) ? "" : ptr);
+			pr_warn("%s: kicking failed bitmap file %pD4 from array!\n",
+				bmname(bitmap), bitmap->storage.file);
 
-			kfree(path);
 		} else
 			pr_warn("%s: disabling internal bitmap due to errors\n",
 				bmname(bitmap));
-- 
2.39.2


  parent reply	other threads:[~2023-06-15  6:50 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15  6:48 deprecate md bitmap file support Christoph Hellwig
2023-06-15  6:48 ` [PATCH 01/11] md-bitmap: set BITMAP_WRITE_ERROR in write_sb_page Christoph Hellwig
2023-06-15  6:56   ` Hannes Reinecke
2023-06-15 14:22   ` Johannes Thumshirn
2023-06-15 17:05   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 02/11] md-bitmap: initialize variables at declaration time in md_bitmap_file_unmap Christoph Hellwig
2023-06-15  6:56   ` Hannes Reinecke
2023-06-15 14:23   ` Johannes Thumshirn
2023-06-15 17:05   ` Himanshu Madhani
2023-06-15  6:48 ` Christoph Hellwig [this message]
2023-06-15  6:58   ` [PATCH 03/11] md-bitmap: use %pD to print the file name in md_bitmap_file_kick Hannes Reinecke
2023-06-15 14:24   ` Johannes Thumshirn
2023-06-15 18:12   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 04/11] md-bitmap: split file writes into a separate helper Christoph Hellwig
2023-06-15  6:59   ` Hannes Reinecke
2023-06-15 14:26   ` Johannes Thumshirn
2023-06-15 18:13   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 05/11] md-bitmap: rename read_page to read_file_page Christoph Hellwig
2023-06-15  6:59   ` Hannes Reinecke
2023-06-15 14:38   ` Johannes Thumshirn
2023-06-15 18:14   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 06/11] md-bitmap: refactor md_bitmap_init_from_disk Christoph Hellwig
2023-06-15 21:59   ` kernel test robot
2023-06-16  6:53     ` Song Liu
2023-06-16  7:01       ` Christoph Hellwig
2023-06-15  6:48 ` [PATCH 07/11] md-bitmap: cleanup read_sb_page Christoph Hellwig
2023-06-15  8:24   ` Hannes Reinecke
2023-06-15 14:42   ` Johannes Thumshirn
2023-06-15 18:30   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 08/11] md-bitmap: account for mddev->bitmap_info.offset in read_sb_page Christoph Hellwig
2023-06-15  8:25   ` Hannes Reinecke
2023-06-15 18:38   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 09/11] md-bitmap: don't use ->index for pages backing the bitmap file Christoph Hellwig
2023-06-15  8:37   ` Hannes Reinecke
2023-06-15  6:48 ` [PATCH 10/11] md: make bitmap file support optional Christoph Hellwig
2023-06-15  8:37   ` Hannes Reinecke
2023-06-15 19:37   ` Himanshu Madhani
2023-06-15  6:48 ` [PATCH 11/11] md: deprecate bitmap file support Christoph Hellwig
2023-06-15  8:38   ` Hannes Reinecke
2023-06-15 19:37   ` Himanshu Madhani
2023-06-15 19:37     ` Himanshu Madhani
2023-06-15  8:05 ` deprecate md " Mariusz Tkaczyk
2023-06-16  7:01   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615064840.629492-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox