Re: [PATCH 02/11] md-bitmap: initialize variables at declaration time in md_bitmap_file_unmap

[Hannes Reinecke <hare@suse.de>]

On 6/15/23 08:48, Christoph Hellwig wrote:
> Just a small tidyup to prepare for bigger changes.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/md/md-bitmap.c | 12 ++++--------
>   1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index d8469720fac23f..0b2d8933cbc75e 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -842,14 +842,10 @@ static int md_bitmap_storage_alloc(struct bitmap_storage *store,
>   
>   static void md_bitmap_file_unmap(struct bitmap_storage *store)
>   {
> -	struct page **map, *sb_page;
> -	int pages;
> -	struct file *file;
> -
> -	file = store->file;
> -	map = store->filemap;
> -	pages = store->file_pages;
> -	sb_page = store->sb_page;
> +	struct file *file = store->file;
> +	struct page *sb_page = store->sb_page;
> +	struct page **map = store->filemap;
> +	int pages = store->file_pages;
>   
>   	while (pages--)
>   		if (map[pages] != sb_page) /* 0 is sb_page, release it below */
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman