public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: "min15.li" <min15.li@samsung.com>
To: axboe@kernel.dk, willy@infradead.org, hch@lst.de,
	dlemoal@kernel.org, gregkh@linuxfoundation.org, wsa@kernel.org,
	vkoul@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	"min15.li" <min15.li@samsung.com>
Subject: [PATCH] block: add capacity validation in bdev_add_partition()
Date: Thu, 15 Jun 2023 16:09:29 +0000	[thread overview]
Message-ID: <20230615160929.9240-1-min15.li@samsung.com> (raw)
In-Reply-To: CGME20230615081227epcas5p40cd9cdf762fcaeedaa8cf8d92d425560@epcas5p4.samsung.com

In the function bdev_add_partition(),there is no check that the start
and end sectors exceed the size of the disk before calling add_partition.
When we call the block's ioctl interface directly to add a partition,
and the capacity of the disk is set to 0 by driver,the command will
continue to execute.

Signed-off-by: min15.li <min15.li@samsung.com>
---
 block/partitions/core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 49e0496ff23c..9806a804e1a4 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -445,6 +445,12 @@ int bdev_add_partition(struct gendisk *disk, int partno, sector_t start,
 		goto out;
 	}
 
+	if (start >= get_capacity(disk) ||
+		start + length > get_capacity(disk)) {
+		ret = -EINVAL;
+		goto out;
+	}
+
 	if (partition_overlaps(disk, start, length, -1)) {
 		ret = -EBUSY;
 		goto out;
-- 
2.34.1


       reply	other threads:[~2023-06-15  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230615081227epcas5p40cd9cdf762fcaeedaa8cf8d92d425560@epcas5p4.samsung.com>
2023-06-15 16:09 ` min15.li [this message]
2023-06-15  8:42   ` [PATCH] block: add capacity validation in bdev_add_partition() Damien Le Moal
2023-06-15  8:44   ` Christoph Hellwig
2023-06-15  8:45   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615160929.9240-1-min15.li@samsung.com \
    --to=min15.li@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    --cc=willy@infradead.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox