From: Christoph Hellwig <hch@infradead.org>
To: "min15.li" <min15.li@samsung.com>
Cc: axboe@kernel.dk, willy@infradead.org, hch@lst.de,
dlemoal@kernel.org, gregkh@linuxfoundation.org, wsa@kernel.org,
vkoul@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: add capacity validation in bdev_add_partition()
Date: Thu, 15 Jun 2023 01:44:19 -0700 [thread overview]
Message-ID: <ZIrPY2fS7LJI9voI@infradead.org> (raw)
In-Reply-To: <20230615160929.9240-1-min15.li@samsung.com>
On Thu, Jun 15, 2023 at 04:09:29PM +0000, min15.li wrote:
> + if (start >= get_capacity(disk) ||
> + start + length > get_capacity(disk)) {
We need to check for overflows of the start + length value,
probably best using a helper like check_add_overflow.
Also a single tab indent (and thus the same as code below) is always
wrong for continuations, plase use either two tabs or align to the
opening brace.
next prev parent reply other threads:[~2023-06-15 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230615081227epcas5p40cd9cdf762fcaeedaa8cf8d92d425560@epcas5p4.samsung.com>
2023-06-15 16:09 ` [PATCH] block: add capacity validation in bdev_add_partition() min15.li
2023-06-15 8:42 ` Damien Le Moal
2023-06-15 8:44 ` Christoph Hellwig [this message]
2023-06-15 8:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIrPY2fS7LJI9voI@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min15.li@samsung.com \
--cc=vkoul@kernel.org \
--cc=willy@infradead.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox