public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Hindborg <nmi@metaspace.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-kernel@vger.kernel.org (open list),
	linux-block@vger.kernel.org (open list:BLOCK LAYER),
	Andreas Hindborg <a.hindborg@samsung.com>,
	Minwoo Im <minwoo.im.dev@gmail.com>,
	Matias Bjorling <Matias.Bjorling@wdc.com>,
	gost.dev@samsung.com, Jens Axboe <axboe@kernel.dk>,
	Aravind Ramesh <Aravind.Ramesh@wdc.com>,
	Johannes Thumshirn <jth@kernel.org>,
	Hans Holmberg <Hans.Holmberg@wdc.com>,
	Christoph Hellwig <hch@infradead.org>,
	Damien Le Moal <dlemoal@kernel.org>
Subject: [PATCH v6 2/3] ublk: add helper to check if device supports user copy
Date: Thu,  6 Jul 2023 15:09:29 +0200	[thread overview]
Message-ID: <20230706130930.64283-3-nmi@metaspace.dk> (raw)
In-Reply-To: <20230706130930.64283-1-nmi@metaspace.dk>

From: Andreas Hindborg <a.hindborg@samsung.com>

This will be used by ublk zoned storage support.

Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>
---
 drivers/block/ublk_drv.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 1c823750c95a..8d271901efac 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -185,6 +185,11 @@ struct ublk_params_header {
 	__u32	types;
 };
 
+static inline bool ublk_dev_is_user_copy(const struct ublk_device *ub)
+{
+	return ub->dev_info.flags & UBLK_F_USER_COPY;
+}
+
 static inline void __ublk_complete_rq(struct request *req);
 static void ublk_complete_rq(struct kref *ref);
 
@@ -2037,7 +2042,7 @@ static int ublk_ctrl_add_dev(struct io_uring_cmd *cmd)
 		UBLK_F_URING_CMD_COMP_IN_TASK;
 
 	/* GET_DATA isn't needed any more with USER_COPY */
-	if (ub->dev_info.flags & UBLK_F_USER_COPY)
+	if (ublk_dev_is_user_copy(ub))
 		ub->dev_info.flags &= ~UBLK_F_NEED_GET_DATA;
 
 	/* We are not ready to support zero copy */
-- 
2.41.0


  parent reply	other threads:[~2023-07-06 13:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 13:09 [PATCH v6 0/3] ublk: enable zoned storage support Andreas Hindborg
2023-07-06 13:09 ` [PATCH v6 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT Andreas Hindborg
2023-07-06 23:50   ` Damien Le Moal
2023-07-07  0:59     ` Ming Lei
2023-07-07  1:42       ` Damien Le Moal
2023-07-10  6:52       ` Christoph Hellwig
2023-07-10  9:27         ` Ming Lei
2023-07-10  9:32           ` Christoph Hellwig
2023-07-10 10:02             ` Ming Lei
2023-07-11  6:23             ` Andreas Hindborg (Samsung)
2023-07-11  8:22               ` Christoph Hellwig
2023-07-11  9:02                 ` Andreas Hindborg (Samsung)
2023-07-11  9:27                   ` Christoph Hellwig
2023-07-11 10:15                     ` Andreas Hindborg (Samsung)
2023-07-11 12:01                       ` Christoph Hellwig
2023-07-06 13:09 ` Andreas Hindborg [this message]
2023-07-06 23:50   ` [PATCH v6 2/3] ublk: add helper to check if device supports user copy Damien Le Moal
2023-07-07  1:02   ` Ming Lei
2023-07-06 13:09 ` [PATCH v6 3/3] ublk: enable zoned storage support Andreas Hindborg
2023-07-07  0:19   ` Damien Le Moal
2023-07-07  6:53     ` Andreas Hindborg (Samsung)
2023-07-07 10:59   ` Ming Lei
2023-07-07 15:04     ` Andreas Hindborg (Samsung)
2023-07-08 14:11       ` Ming Lei
2023-07-10  6:07         ` Andreas Hindborg (Samsung)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230706130930.64283-3-nmi@metaspace.dk \
    --to=nmi@metaspace.dk \
    --cc=Aravind.Ramesh@wdc.com \
    --cc=Hans.Holmberg@wdc.com \
    --cc=Matias.Bjorling@wdc.com \
    --cc=a.hindborg@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hch@infradead.org \
    --cc=jth@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox