From: Christoph Hellwig <hch@lst.de>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Christoph Hellwig <hch@lst.de>,
Chuck Lever III <chuck.lever@oracle.com>,
Jens Axboe <axboe@kernel.dk>, Chuck Lever <cel@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH RFC] block: Revert 615939a2ae73
Date: Thu, 10 Aug 2023 17:58:35 +0200 [thread overview]
Message-ID: <20230810155835.GF28000@lst.de> (raw)
In-Reply-To: <86ce2299-ce42-c0bb-e577-9d23f8af494c@bytedance.com>
On Thu, Aug 10, 2023 at 11:42:50AM +0800, Chengming Zhou wrote:
> Christoph, it would be very helpful if you share some thoughts
> and directions.
I am not quite sure where the problems could even be. I think the
interesting aspects are:
- we are not directly processing through the normal submission path
instead of adding the command to the flush_data_in_flight list and
then going through blk_kick_flush. So a command now gets executed
earlier than it did before.
- given that it only happens with SATA, it must be in some way related
to the fact that ATA flush commands are not queud, that is when a
flush is outstanding no other command can't.
next prev parent reply other threads:[~2023-08-10 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:08 [PATCH RFC] block: Revert 615939a2ae73 Chuck Lever
2023-08-09 15:51 ` Jens Axboe
2023-08-09 16:11 ` Christoph Hellwig
2023-08-09 16:26 ` Chuck Lever III
2023-08-09 21:49 ` Christoph Hellwig
2023-08-10 3:42 ` Chengming Zhou
2023-08-10 13:47 ` Chuck Lever III
2023-08-10 15:58 ` Christoph Hellwig [this message]
2023-08-10 16:02 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810155835.GF28000@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox