From: Jens Axboe <axboe@kernel.dk>
To: Chuck Lever <cel@kernel.org>, linux-block@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH RFC] block: Revert 615939a2ae73
Date: Wed, 9 Aug 2023 09:51:18 -0600 [thread overview]
Message-ID: <d51b0683-8872-4e10-8589-5c6de8db61d4@kernel.dk> (raw)
In-Reply-To: <169158653156.2034.8363987273532378512.stgit@bazille.1015granger.net>
On 8/9/23 7:08 AM, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Even after commit 9f87fc4d72f5 ("block: queue data commands from the
> flush state machine at the head"), I'm still seeing hangs on NFS
> exports that reside on SATA devices.
>
> Bisected to commit 615939a2ae73 ("blk-mq: defer to the normal
> submission path for post-flush requests"). I've tested reverting
> that commit on several kernels from 0aa69d53ac7c ("Merge tag
> 'for-6.5/io_uring-2023-06-23' of git://git.kernel.dk/linux") to
> v6.5-rc5, and it seems to address the problem.
>
> I also confirmed that commit 9f87fc4d72f5 ("block: queue data
> commands from the flush state machine at the head") is still
> necessary.
Adding the author - Christoph?
--
Jens Axboe
next prev parent reply other threads:[~2023-08-09 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:08 [PATCH RFC] block: Revert 615939a2ae73 Chuck Lever
2023-08-09 15:51 ` Jens Axboe [this message]
2023-08-09 16:11 ` Christoph Hellwig
2023-08-09 16:26 ` Chuck Lever III
2023-08-09 21:49 ` Christoph Hellwig
2023-08-10 3:42 ` Chengming Zhou
2023-08-10 13:47 ` Chuck Lever III
2023-08-10 15:58 ` Christoph Hellwig
2023-08-10 16:02 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d51b0683-8872-4e10-8589-5c6de8db61d4@kernel.dk \
--to=axboe@kernel.dk \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox