* [PATCH] block: Use pr_info() instead of printk(KERN_INFO ...)
@ 2023-12-13 19:47 Bart Van Assche
2023-12-13 19:57 ` Keith Busch
2023-12-14 17:29 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2023-12-13 19:47 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, Christoph Hellwig, Bart Van Assche, Luis Chamberlain,
Ming Lei, Keith Busch
Switch to the modern style of printing kernel messages. Use %u instead
of %d to print unsigned integers.
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Keith Busch <kbusch@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-settings.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/block/blk-settings.c b/block/blk-settings.c
index 0046b447268f..09e3a4d5e4d2 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -127,8 +127,7 @@ void blk_queue_max_hw_sectors(struct request_queue *q, unsigned int max_hw_secto
if ((max_hw_sectors << 9) < PAGE_SIZE) {
max_hw_sectors = 1 << (PAGE_SHIFT - 9);
- printk(KERN_INFO "%s: set to minimum %d\n",
- __func__, max_hw_sectors);
+ pr_info("%s: set to minimum %u\n", __func__, max_hw_sectors);
}
max_hw_sectors = round_down(max_hw_sectors,
@@ -248,8 +247,7 @@ void blk_queue_max_segments(struct request_queue *q, unsigned short max_segments
{
if (!max_segments) {
max_segments = 1;
- printk(KERN_INFO "%s: set to minimum %d\n",
- __func__, max_segments);
+ pr_info("%s: set to minimum %u\n", __func__, max_segments);
}
q->limits.max_segments = max_segments;
@@ -285,8 +283,7 @@ void blk_queue_max_segment_size(struct request_queue *q, unsigned int max_size)
{
if (max_size < PAGE_SIZE) {
max_size = PAGE_SIZE;
- printk(KERN_INFO "%s: set to minimum %d\n",
- __func__, max_size);
+ pr_info("%s: set to minimum %u\n", __func__, max_size);
}
/* see blk_queue_virt_boundary() for the explanation */
@@ -740,8 +737,7 @@ void blk_queue_segment_boundary(struct request_queue *q, unsigned long mask)
{
if (mask < PAGE_SIZE - 1) {
mask = PAGE_SIZE - 1;
- printk(KERN_INFO "%s: set to minimum %lx\n",
- __func__, mask);
+ pr_info("%s: set to minimum %lx\n", __func__, mask);
}
q->limits.seg_boundary_mask = mask;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Use pr_info() instead of printk(KERN_INFO ...)
2023-12-13 19:47 [PATCH] block: Use pr_info() instead of printk(KERN_INFO ...) Bart Van Assche
@ 2023-12-13 19:57 ` Keith Busch
2023-12-14 17:29 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2023-12-13 19:57 UTC (permalink / raw)
To: Bart Van Assche
Cc: Jens Axboe, linux-block, Christoph Hellwig, Luis Chamberlain,
Ming Lei
On Wed, Dec 13, 2023 at 11:47:02AM -0800, Bart Van Assche wrote:
> Switch to the modern style of printing kernel messages. Use %u instead
> of %d to print unsigned integers.
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Use pr_info() instead of printk(KERN_INFO ...)
2023-12-13 19:47 [PATCH] block: Use pr_info() instead of printk(KERN_INFO ...) Bart Van Assche
2023-12-13 19:57 ` Keith Busch
@ 2023-12-14 17:29 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-12-14 17:29 UTC (permalink / raw)
To: Bart Van Assche
Cc: linux-block, Christoph Hellwig, Luis Chamberlain, Ming Lei,
Keith Busch
On Wed, 13 Dec 2023 11:47:02 -0800, Bart Van Assche wrote:
> Switch to the modern style of printing kernel messages. Use %u instead
> of %d to print unsigned integers.
>
>
Applied, thanks!
[1/1] block: Use pr_info() instead of printk(KERN_INFO ...)
commit: f19d1e3b17acc8173cd83b189f4c9506889b1c49
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-14 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-13 19:47 [PATCH] block: Use pr_info() instead of printk(KERN_INFO ...) Bart Van Assche
2023-12-13 19:57 ` Keith Busch
2023-12-14 17:29 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox