From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <willy@infradead.org>, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: handle BLK_OPEN_RESTRICT_WRITES correctly
Date: Sat, 23 Mar 2024 16:59:43 +0100 [thread overview]
Message-ID: <20240323-hingabe-burganlage-ae4a22611a71@brauner> (raw)
In-Reply-To: <20240323-seide-erbrachten-5c60873fadc1@brauner>
> + /*
> + * If this was an exclusive open and writes are blocked
> + * we know that we're the ones who blocked them.
> + */
> + if (bdev_file->private_data && bdev_writes_blocked(bdev))
This doesn't work because this will unblock BLK_OPEN_RESTRICT_WRITES
when the block device has been opened read-only but exclusively, i.e.,
when e.g., userspace requested read-only access and we use the file as
the holder. I have an alternative fix.
next prev parent reply other threads:[~2024-03-23 15:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 14:54 [PATCH] block: handle BLK_OPEN_RESTRICT_WRITES correctly Christian Brauner
2024-03-23 15:59 ` Christian Brauner [this message]
2024-03-23 16:11 ` [PATCH 1/2] " Christian Brauner
2024-03-23 16:11 ` [PATCH 2/2] [RFC]: block: count BLK_OPEN_RESTRICT_WRITES openers Christian Brauner
2024-03-26 13:24 ` Jan Kara
2024-03-25 11:51 ` [PATCH 1/2] block: handle BLK_OPEN_RESTRICT_WRITES correctly Yu Kuai
2024-03-25 12:04 ` Christian Brauner
2024-03-25 13:52 ` Yu Kuai
2024-03-25 13:54 ` Christian Brauner
2024-03-26 1:32 ` Yu Kuai
2024-03-26 12:57 ` Jan Kara
2024-03-26 13:17 ` Christian Brauner
2024-03-26 13:31 ` Jan Kara
2024-03-26 15:46 ` [PATCH v2] " Christian Brauner
2024-03-26 17:25 ` Christoph Hellwig
2024-03-26 22:42 ` Jan Kara
2024-03-26 15:47 ` [PATCH 1/2] " Christian Brauner
2024-03-27 12:01 ` Christian Brauner
2024-03-29 4:56 ` Matthew Wilcox
2024-03-29 12:10 ` Christian Brauner
2024-03-29 15:11 ` Christian Brauner
2024-03-29 15:24 ` Christian Brauner
2024-04-03 6:04 ` Christian Brauner
2024-04-03 19:22 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240323-hingabe-burganlage-ae4a22611a71@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox