* [PATCH] block: fix get_max_segment_size() warning
@ 2024-07-09 4:54 Chaitanya Kulkarni
2024-07-09 5:44 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2024-07-09 4:54 UTC (permalink / raw)
To: linux-block; +Cc: axboe, hch, Chaitanya Kulkarni
Correct the parameter name in the comment of get_max_segment_size()
to fix following warning:-
block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size'
block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size'
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
block/blk-merge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 94502261e24a..668b784bc246 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -210,7 +210,7 @@ static inline unsigned get_max_io_size(struct bio *bio,
* get_max_segment_size() - maximum number of bytes to add as a single segment
* @lim: Request queue limits.
* @paddr: address of the range to add
- * @max_len: maximum length available to add at @paddr
+ * @len: maximum length available to add at @paddr
*
* Returns the maximum number of bytes of the range starting at @paddr that can
* be added to a single segment.
--
2.40.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] block: fix get_max_segment_size() warning
2024-07-09 4:54 [PATCH] block: fix get_max_segment_size() warning Chaitanya Kulkarni
@ 2024-07-09 5:44 ` Damien Le Moal
2024-07-09 6:01 ` Jens Axboe
2024-07-09 6:20 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2024-07-09 5:44 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block; +Cc: axboe, hch
On 7/9/24 13:54, Chaitanya Kulkarni wrote:
> Correct the parameter name in the comment of get_max_segment_size()
> to fix following warning:-
>
> block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size'
> block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size'
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: fix get_max_segment_size() warning
2024-07-09 4:54 [PATCH] block: fix get_max_segment_size() warning Chaitanya Kulkarni
2024-07-09 5:44 ` Damien Le Moal
@ 2024-07-09 6:01 ` Jens Axboe
2024-07-09 6:20 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-07-09 6:01 UTC (permalink / raw)
To: linux-block, Chaitanya Kulkarni; +Cc: hch
On Mon, 08 Jul 2024 21:54:32 -0700, Chaitanya Kulkarni wrote:
> Correct the parameter name in the comment of get_max_segment_size()
> to fix following warning:-
>
> block/blk-merge.c:220: warning: Function parameter or struct member 'len' not described in 'get_max_segment_size'
> block/blk-merge.c:220: warning: Excess function parameter 'max_len' description in 'get_max_segment_size'
>
>
> [...]
Applied, thanks!
[1/1] block: fix get_max_segment_size() warning
commit: 0ffc46eb1b6d0b9dd07e4f2b1019edd4fe678b9e
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: fix get_max_segment_size() warning
2024-07-09 4:54 [PATCH] block: fix get_max_segment_size() warning Chaitanya Kulkarni
2024-07-09 5:44 ` Damien Le Moal
2024-07-09 6:01 ` Jens Axboe
@ 2024-07-09 6:20 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-07-09 6:20 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-block, axboe, hch
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-09 6:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 4:54 [PATCH] block: fix get_max_segment_size() warning Chaitanya Kulkarni
2024-07-09 5:44 ` Damien Le Moal
2024-07-09 6:01 ` Jens Axboe
2024-07-09 6:20 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox