From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yang Ruibin <11162571@vivo.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v4] drivers:block:Cancel debugfs_create_dir() check
Date: Fri, 23 Aug 2024 21:02:23 +0800 [thread overview]
Message-ID: <2024082346-delivery-oblong-cd4c@gregkh> (raw)
In-Reply-To: <20240823112246.3905118-1-11162571@vivo.com>
On Fri, Aug 23, 2024 at 07:22:45PM +0800, Yang Ruibin wrote:
> No need to check debugfs_create_dir() return value.
> It's safe to pass in errors that debugfs_create_dir() gives you.
>
> Fixes: f40eb99897af ("pktcdvd: remove driver.")
It's not a "fix", it's just a cleanup. The current code just never
actually triggers so it's not like there is any functional change here
at all.
thanks,
greg k-h
next prev parent reply other threads:[~2024-08-23 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 11:22 [PATCH v4] drivers:block:Cancel debugfs_create_dir() check Yang Ruibin
2024-08-23 13:02 ` Greg Kroah-Hartman [this message]
2024-08-23 13:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024082346-delivery-oblong-cd4c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=11162571@vivo.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox