[PATCH v4] drivers:block:Cancel debugfs_create_dir() check

[PATCH v4] drivers:block:Cancel debugfs_create_dir() check

[Yang Ruibin]

No need to check debugfs_create_dir() return value.
It's safe to pass in errors that debugfs_create_dir() gives you.

Fixes: f40eb99897af ("pktcdvd: remove driver.")
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
Changes V4:
- Remove the check for the return value of debugfs_create_dir()
---
 drivers/block/pktcdvd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 7cece5884b9c..3edb37a41312 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -498,8 +498,6 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
 	if (!pkt_debugfs_root)
 		return;
 	pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
-	if (!pd->dfs_d_root)
-		return;
 
 	pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
 					     pd, &pkt_seq_fops);
-- 
2.34.1

Re: [PATCH v4] drivers:block:Cancel debugfs_create_dir() check

[Greg Kroah-Hartman]

On Fri, Aug 23, 2024 at 07:22:45PM +0800, Yang Ruibin wrote:
> No need to check debugfs_create_dir() return value.
> It's safe to pass in errors that debugfs_create_dir() gives you.
> 
> Fixes: f40eb99897af ("pktcdvd: remove driver.")

It's not a "fix", it's just a cleanup.  The current code just never
actually triggers so it's not like there is any functional change here
at all.

thanks,

greg k-h

Re: [PATCH v4] drivers:block:Cancel debugfs_create_dir() check

[Jens Axboe]

On 8/23/24 5:22 AM, Yang Ruibin wrote:
> No need to check debugfs_create_dir() return value.
> It's safe to pass in errors that debugfs_create_dir() gives you.

Subject line is still wrong, as has been mentioned before for your
posting. If in doubt, just run git log on a file and see what the
customary title prefix is for a given file.

-- 
Jens Axboe