From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hare@suse.de, martin.petersen@oracle.com,
catherine.hoang@oracle.com, mcgrof@kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v6 0/7] block atomic writes for xfs
Date: Mon, 30 Sep 2024 12:54:31 +0000 [thread overview]
Message-ID: <20240930125438.2501050-1-john.g.garry@oracle.com> (raw)
This series expands atomic write support to filesystems, specifically
XFS.
Flag FS_XFLAG_ATOMICWRITES is added as an enabling flag for atomic writes.
XFS can be formatted for atomic writes as follows:
mkfs.xfs -i atomicwrites=1 -b size=16384 /dev/sda
Support can be enabled through xfs_io command:
$xfs_io -c "chattr +W" filename
$xfs_io -c "lsattr -v" filename
[atomic-writes] filename
$xfs_io -c statx filename
...
stat.stx_atomic_write_unit_min = 16384
stat.stx_atomic_write_unit_max = 16384
stat.stx_atomic_write_segments_max = 1
...
Dependence on forcealign is gone for the moment. This means that we can
only write a single FS block atomically. Since we can now have FS block
size > PAGE_SIZE for XFS, we can write atomically write > 4K blocks on
x86.
Using the large FS block size has downsides, so we still want the
forcealign feature.
Baseline is v6.12-rc1
Basic xfsprogs support at:
https://github.com/johnpgarry/xfsprogs-dev/tree/atomic-writes-v6
Patches for this series can be found at:
https://github.com/johnpgarry/linux/tree/atomic-writes-v6.12-fs-v6
Changes since v5:
- Drop forcealign dependency
- Can support atomically writing a single FS block
- XFS_DIFLAG2_ATOMICWRITES is inherited from parent directories
- Add RB tags from Darrick (thanks!)
Changes since v4:
- Drop iomap extent-based zeroing and use single bio to cover multiple
extents
- Move forcealign to another series
- Various change in ioctl, sb, inode validation
- Add patch to tweak generic_atomic_write_valid() API
John Garry (7):
block/fs: Pass an iocb to generic_atomic_write_valid()
fs: Export generic_atomic_write_valid()
fs: iomap: Atomic write support
xfs: Support FS_XFLAG_ATOMICWRITES
xfs: Support atomic write for statx
xfs: Validate atomic writes
xfs: Support setting FMODE_CAN_ATOMIC_WRITE
block/fops.c | 8 +++----
fs/iomap/direct-io.c | 26 ++++++++++++++++++++---
fs/iomap/trace.h | 3 ++-
fs/read_write.c | 5 +++--
fs/xfs/libxfs/xfs_format.h | 11 ++++++++--
fs/xfs/libxfs/xfs_inode_buf.c | 38 ++++++++++++++++++++++++++++++++++
fs/xfs/libxfs/xfs_inode_util.c | 6 ++++++
fs/xfs/libxfs/xfs_sb.c | 2 ++
fs/xfs/xfs_buf.c | 15 +++++++++++++-
fs/xfs/xfs_buf.h | 5 ++++-
fs/xfs/xfs_buf_mem.c | 2 +-
fs/xfs/xfs_file.c | 19 +++++++++++++++++
fs/xfs/xfs_inode.h | 22 ++++++++++++++++++++
fs/xfs/xfs_ioctl.c | 37 +++++++++++++++++++++++++++++++++
fs/xfs/xfs_iops.c | 24 +++++++++++++++++++++
fs/xfs/xfs_mount.h | 2 ++
fs/xfs/xfs_reflink.c | 4 ++++
fs/xfs/xfs_super.c | 4 ++++
include/linux/fs.h | 2 +-
include/linux/iomap.h | 1 +
include/uapi/linux/fs.h | 1 +
21 files changed, 221 insertions(+), 16 deletions(-)
--
2.31.1
next reply other threads:[~2024-09-30 12:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 12:54 John Garry [this message]
2024-09-30 12:54 ` [PATCH v6 1/7] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-01 8:39 ` Christoph Hellwig
2024-09-30 12:54 ` [PATCH v6 2/7] fs: Export generic_atomic_write_valid() John Garry
2024-10-01 8:41 ` Christoph Hellwig
2024-09-30 12:54 ` [PATCH v6 3/7] fs: iomap: Atomic write support John Garry
2024-09-30 15:55 ` Darrick J. Wong
2024-10-01 8:05 ` John Garry
2024-10-01 14:37 ` Darrick J. Wong
2024-09-30 12:54 ` [PATCH v6 4/7] xfs: Support FS_XFLAG_ATOMICWRITES John Garry
2024-09-30 16:03 ` Darrick J. Wong
2024-09-30 16:44 ` Darrick J. Wong
2024-10-01 8:41 ` Christoph Hellwig
2024-10-01 12:05 ` John Garry
2024-10-01 13:35 ` John Garry
2024-10-03 12:48 ` John Garry
2024-10-03 13:02 ` Christoph Hellwig
2024-10-03 13:19 ` John Garry
2024-09-30 12:54 ` [PATCH v6 5/7] xfs: Support atomic write for statx John Garry
2024-09-30 16:37 ` Darrick J. Wong
2024-10-01 8:29 ` John Garry
2024-10-01 8:43 ` Christoph Hellwig
2024-09-30 12:54 ` [PATCH v6 6/7] xfs: Validate atomic writes John Garry
2024-09-30 16:41 ` Darrick J. Wong
2024-10-01 13:22 ` John Garry
2024-10-01 14:48 ` Darrick J. Wong
2024-10-01 15:48 ` John Garry
2024-09-30 12:54 ` [PATCH v6 7/7] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-09-30 16:41 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930125438.2501050-1-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox