From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hare@suse.de, martin.petersen@oracle.com,
catherine.hoang@oracle.com, mcgrof@kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com,
John Garry <john.g.garry@oracle.com>
Subject: [PATCH v6 6/7] xfs: Validate atomic writes
Date: Mon, 30 Sep 2024 12:54:37 +0000 [thread overview]
Message-ID: <20240930125438.2501050-7-john.g.garry@oracle.com> (raw)
In-Reply-To: <20240930125438.2501050-1-john.g.garry@oracle.com>
Validate that an atomic write adheres to length/offset rules. Currently
we can only write a single FS block.
For an IOCB with IOCB_ATOMIC set to get as far as xfs_file_dio_write(),
FMODE_CAN_ATOMIC_WRITE will need to be set for the file; for this,
ATOMICWRITES flags would also need to be set for the inode.
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
fs/xfs/xfs_file.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 412b1d71b52b..fa6a44b88ecc 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -688,6 +688,13 @@ xfs_file_dio_write(
struct xfs_buftarg *target = xfs_inode_buftarg(ip);
size_t count = iov_iter_count(from);
+ if (iocb->ki_flags & IOCB_ATOMIC) {
+ if (count != ip->i_mount->m_sb.sb_blocksize)
+ return -EINVAL;
+ if (!generic_atomic_write_valid(iocb, from))
+ return -EINVAL;
+ }
+
/* direct I/O must be aligned to device logical sector size */
if ((iocb->ki_pos | count) & target->bt_logical_sectormask)
return -EINVAL;
--
2.31.1
next prev parent reply other threads:[~2024-09-30 12:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 12:54 [PATCH v6 0/7] block atomic writes for xfs John Garry
2024-09-30 12:54 ` [PATCH v6 1/7] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-01 8:39 ` Christoph Hellwig
2024-09-30 12:54 ` [PATCH v6 2/7] fs: Export generic_atomic_write_valid() John Garry
2024-10-01 8:41 ` Christoph Hellwig
2024-09-30 12:54 ` [PATCH v6 3/7] fs: iomap: Atomic write support John Garry
2024-09-30 15:55 ` Darrick J. Wong
2024-10-01 8:05 ` John Garry
2024-10-01 14:37 ` Darrick J. Wong
2024-09-30 12:54 ` [PATCH v6 4/7] xfs: Support FS_XFLAG_ATOMICWRITES John Garry
2024-09-30 16:03 ` Darrick J. Wong
2024-09-30 16:44 ` Darrick J. Wong
2024-10-01 8:41 ` Christoph Hellwig
2024-10-01 12:05 ` John Garry
2024-10-01 13:35 ` John Garry
2024-10-03 12:48 ` John Garry
2024-10-03 13:02 ` Christoph Hellwig
2024-10-03 13:19 ` John Garry
2024-09-30 12:54 ` [PATCH v6 5/7] xfs: Support atomic write for statx John Garry
2024-09-30 16:37 ` Darrick J. Wong
2024-10-01 8:29 ` John Garry
2024-10-01 8:43 ` Christoph Hellwig
2024-09-30 12:54 ` John Garry [this message]
2024-09-30 16:41 ` [PATCH v6 6/7] xfs: Validate atomic writes Darrick J. Wong
2024-10-01 13:22 ` John Garry
2024-10-01 14:48 ` Darrick J. Wong
2024-10-01 15:48 ` John Garry
2024-09-30 12:54 ` [PATCH v6 7/7] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-09-30 16:41 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930125438.2501050-7-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox