From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v2 1/3] block: Optimize blk_mq_submit_bio() for the cache hit scenario
Date: Tue, 17 Dec 2024 14:38:07 -0800 [thread overview]
Message-ID: <20241217223809.683035-2-bvanassche@acm.org> (raw)
In-Reply-To: <20241217223809.683035-1-bvanassche@acm.org>
Help the CPU branch predictor in case of a cache hit by handling the cache
hit scenario first.
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-mq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 7ee21346a41e..8d2aab4d9ba9 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3102,12 +3102,12 @@ void blk_mq_submit_bio(struct bio *bio)
goto queue_exit;
new_request:
- if (!rq) {
+ if (rq) {
+ blk_mq_use_cached_rq(rq, plug, bio);
+ } else {
rq = blk_mq_get_new_requests(q, plug, bio, nr_segs);
if (unlikely(!rq))
goto queue_exit;
- } else {
- blk_mq_use_cached_rq(rq, plug, bio);
}
trace_block_getrq(bio);
next prev parent reply other threads:[~2024-12-17 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 22:38 [PATCH v2 0/3] Three blk_mq_submit_bio() patches Bart Van Assche
2024-12-17 22:38 ` Bart Van Assche [this message]
2024-12-17 23:36 ` [PATCH v2 1/3] block: Optimize blk_mq_submit_bio() for the cache hit scenario Damien Le Moal
2024-12-17 22:38 ` [PATCH v2 2/3] blk-mq: Move more error handling into blk_mq_submit_bio() Bart Van Assche
2024-12-17 23:37 ` Damien Le Moal
2024-12-18 17:35 ` Bart Van Assche
2024-12-17 22:38 ` [PATCH v2 3/3] blk-zoned: " Bart Van Assche
2024-12-17 23:47 ` Damien Le Moal
2024-12-18 18:21 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217223809.683035-2-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox