From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 3/3] blk-zoned: Move more error handling into blk_mq_submit_bio()
Date: Wed, 18 Dec 2024 10:21:18 -0800 [thread overview]
Message-ID: <c91558c0-6c01-462d-958a-2cb96740f415@acm.org> (raw)
In-Reply-To: <49e2abf5-5c3f-4f0d-bf06-d382a79da393@kernel.org>
On 12/17/24 3:47 PM, Damien Le Moal wrote:
> On 2024/12/17 14:38, Bart Van Assche wrote:
>> The error handling code in blk_zone_plug_bio() and in the functions
>> called by blk_zone_plug_bio() cannot be understood without knowing
>> that these functions are only called by blk_mq_submit_bio(). Move
>> the error handling code in blk_mq_submit_bio() such that all error
>> handling code for blk_mq_submit_bio() occurs inside blk_mq_submit_bio()
>> itself.
>
> I am not a big fan of this. Furthermore, blk_zone_plug_bio() is also called from
> drivers/md/dm.c, which would need to have the same amount of additional code.
> Not nice.
I will drop this patch.
Thanks,
Bart.
prev parent reply other threads:[~2024-12-18 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 22:38 [PATCH v2 0/3] Three blk_mq_submit_bio() patches Bart Van Assche
2024-12-17 22:38 ` [PATCH v2 1/3] block: Optimize blk_mq_submit_bio() for the cache hit scenario Bart Van Assche
2024-12-17 23:36 ` Damien Le Moal
2024-12-17 22:38 ` [PATCH v2 2/3] blk-mq: Move more error handling into blk_mq_submit_bio() Bart Van Assche
2024-12-17 23:37 ` Damien Le Moal
2024-12-18 17:35 ` Bart Van Assche
2024-12-17 22:38 ` [PATCH v2 3/3] blk-zoned: " Bart Van Assche
2024-12-17 23:47 ` Damien Le Moal
2024-12-18 18:21 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91558c0-6c01-462d-958a-2cb96740f415@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox