[PATCH] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion

[PATCH] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion

[Damien Le Moal]

When blk_zone_write_plug_bio_endio() is called for a regular write BIO
used to emulate a zone append operation, that is, a BIO flagged with
BIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the
original REQ_OP_ZONE_APPEND but the BIO_EMULATES_ZONE_APPEND flag is not
cleared. Clear it to fully return the BIO to its orginal definition.

Fixes: 9b1ce7f0c6f8 ("block: Implement zone append emulation")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
 block/blk-zoned.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index dfcef04ea8b4..55e64ca869d7 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -1254,6 +1254,7 @@ void blk_zone_write_plug_bio_endio(struct bio *bio)
 	if (bio_flagged(bio, BIO_EMULATES_ZONE_APPEND)) {
 		bio->bi_opf &= ~REQ_OP_MASK;
 		bio->bi_opf |= REQ_OP_ZONE_APPEND;
+		bio_clear_flag(bio, BIO_EMULATES_ZONE_APPEND);
 	}
 
 	/*
-- 
2.49.0

Re: [PATCH] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion

[Christoph Hellwig]

On Wed, Jun 11, 2025 at 09:59:15AM +0900, Damien Le Moal wrote:
> When blk_zone_write_plug_bio_endio() is called for a regular write BIO
> used to emulate a zone append operation, that is, a BIO flagged with
> BIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the
> original REQ_OP_ZONE_APPEND but the BIO_EMULATES_ZONE_APPEND flag is not
> cleared. Clear it to fully return the BIO to its orginal definition.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion

[Hannes Reinecke]

On 6/11/25 02:59, Damien Le Moal wrote:
> When blk_zone_write_plug_bio_endio() is called for a regular write BIO
> used to emulate a zone append operation, that is, a BIO flagged with
> BIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the
> original REQ_OP_ZONE_APPEND but the BIO_EMULATES_ZONE_APPEND flag is not
> cleared. Clear it to fully return the BIO to its orginal definition.
> 
> Fixes: 9b1ce7f0c6f8 ("block: Implement zone append emulation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>   block/blk-zoned.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index dfcef04ea8b4..55e64ca869d7 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -1254,6 +1254,7 @@ void blk_zone_write_plug_bio_endio(struct bio *bio)
>   	if (bio_flagged(bio, BIO_EMULATES_ZONE_APPEND)) {
>   		bio->bi_opf &= ~REQ_OP_MASK;
>   		bio->bi_opf |= REQ_OP_ZONE_APPEND;
> +		bio_clear_flag(bio, BIO_EMULATES_ZONE_APPEND);
>   	}
>   
>   	/*
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion

[Johannes Thumshirn]

Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Re: [PATCH] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion

[Jens Axboe]

On Wed, 11 Jun 2025 09:59:15 +0900, Damien Le Moal wrote:
> When blk_zone_write_plug_bio_endio() is called for a regular write BIO
> used to emulate a zone append operation, that is, a BIO flagged with
> BIO_EMULATES_ZONE_APPEND, the BIO operation code is restored to the
> original REQ_OP_ZONE_APPEND but the BIO_EMULATES_ZONE_APPEND flag is not
> cleared. Clear it to fully return the BIO to its orginal definition.
> 
> 
> [...]

Applied, thanks!

[1/1] block: Clear BIO_EMULATES_ZONE_APPEND flag on BIO completion
      commit: f705d33c2f0353039d03e5d6f18f70467d86080e

Best regards,
-- 
Jens Axboe