Linux block layer
 help / color / mirror / Atom feed
From: Tang Yizhou <yizhou.tang@shopee.com>
To: axboe@kernel.dk, hch@lst.de, jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	tangyeechou@gmail.com, Tang Yizhou <yizhou.tang@shopee.com>
Subject: [PATCH v2 2/3] blk-wbt: Eliminate ambiguity in the comments of struct rq_wb
Date: Mon, 28 Jul 2025 00:47:08 +0800	[thread overview]
Message-ID: <20250727164709.96477-3-yizhou.tang@shopee.com> (raw)
In-Reply-To: <20250727164709.96477-1-yizhou.tang@shopee.com>

From: Tang Yizhou <yizhou.tang@shopee.com>

In the current implementation, the last_issue and last_comp members of
struct rq_wb are used only by read requests and not by non-throttled write
requests. Therefore, eliminate the ambiguity here.

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 block/blk-wbt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 30886d44f6cd..eb8037bae0bd 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -85,8 +85,8 @@ struct rq_wb {
 	u64 sync_issue;
 	void *sync_cookie;
 
-	unsigned long last_issue;		/* last non-throttled issue */
-	unsigned long last_comp;		/* last non-throttled comp */
+	unsigned long last_issue;	/* issue time of last read rq */
+	unsigned long last_comp;	/* completion time of last read rq */
 	unsigned long min_lat_nsec;
 	struct rq_qos rqos;
 	struct rq_wait rq_wait[WBT_NUM_RWQ];
-- 
2.25.1


  parent reply	other threads:[~2025-07-27 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 16:47 [PATCH v2 0/3] Optimize wbt and update its comments and doc Tang Yizhou
2025-07-27 16:47 ` [PATCH v2 1/3] blk-wbt: Optimize wbt_done() for non-throttled writes Tang Yizhou
2025-07-27 16:47 ` Tang Yizhou [this message]
2025-07-27 16:47 ` [PATCH v2 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface Tang Yizhou
2025-07-27 17:09   ` Yu Kuai
2025-07-27 17:27     ` Yizhou Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250727164709.96477-3-yizhou.tang@shopee.com \
    --to=yizhou.tang@shopee.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tangyeechou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox