Linux block layer
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai@kernel.org>
To: Tang Yizhou <yizhou.tang@shopee.com>,
	axboe@kernel.dk, hch@lst.de, jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	tangyeechou@gmail.com
Subject: Re: [PATCH v2 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface
Date: Mon, 28 Jul 2025 01:09:07 +0800	[thread overview]
Message-ID: <939f45b2-4481-422a-a747-012808953d7f@kernel.org> (raw)
In-Reply-To: <20250727164709.96477-4-yizhou.tang@shopee.com>

Hi,

在 2025/7/28 0:47, Tang Yizhou 写道:
> From: Tang Yizhou <yizhou.tang@shopee.com>
>
> The symbol wb_window_usec cannot be found. Update the doc to reflect the
> latest implementation, in other words, the cur_win_nsec member of struct
> rq_wb.
>
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
> ---
>   Documentation/ABI/stable/sysfs-block | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> index 4ba771b56b3b..277d89815edd 100644
> --- a/Documentation/ABI/stable/sysfs-block
> +++ b/Documentation/ABI/stable/sysfs-block
> @@ -731,7 +731,7 @@ Contact:	linux-block@vger.kernel.org
>   Description:
>   		[RW] If the device is registered for writeback throttling, then
>   		this file shows the target minimum read latency. If this latency
> -		is exceeded in a given window of time (see wb_window_usec), then
> +		is exceeded in a given window of time (see cur_win_nsec), then
Is this a typo? Jan suggested curr_win_nsec from v1.

BTW, I don't mind rename rwb->cur_win_nsec to curr_win_nsec as well.

Thanks,
Kuai

>   		the writeback throttling will start scaling back writes. Writing
>   		a value of '0' to this file disables the feature. Writing a
>   		value of '-1' to this file resets the value to the default


  reply	other threads:[~2025-07-27 17:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 16:47 [PATCH v2 0/3] Optimize wbt and update its comments and doc Tang Yizhou
2025-07-27 16:47 ` [PATCH v2 1/3] blk-wbt: Optimize wbt_done() for non-throttled writes Tang Yizhou
2025-07-27 16:47 ` [PATCH v2 2/3] blk-wbt: Eliminate ambiguity in the comments of struct rq_wb Tang Yizhou
2025-07-27 16:47 ` [PATCH v2 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface Tang Yizhou
2025-07-27 17:09   ` Yu Kuai [this message]
2025-07-27 17:27     ` Yizhou Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=939f45b2-4481-422a-a747-012808953d7f@kernel.org \
    --to=yukuai@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tangyeechou@gmail.com \
    --cc=yizhou.tang@shopee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox