[PATCH] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation

[PATCH] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation

[Bart Van Assche]

Commit 2dd6532e9591 ("blk-mq: Drop 'reserved' arg of busy_tag_iter_fn")
removed the 'reserved' argument from tag iteration callback functions.
Bring the blk_mq_tagset_busy_iter() documentation in sync with that
change.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-mq-tag.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index a63d21a4aab4..0602ca7f1e37 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -424,10 +424,9 @@ void blk_mq_all_tag_iter(struct blk_mq_tags *tags, busy_tag_iter_fn *fn,
  * blk_mq_tagset_busy_iter - iterate over all started requests in a tag set
  * @tagset:	Tag set to iterate over.
  * @fn:		Pointer to the function that will be called for each started
- *		request. @fn will be called as follows: @fn(rq, @priv,
- *		reserved) where rq is a pointer to a request. 'reserved'
- *		indicates whether or not @rq is a reserved request. Return
- *		true to continue iterating tags, false to stop.
+ *		request. @fn will be called as follows: @fn(rq, @priv) where
+ *		rq is a pointer to a request. Return true to continue iterating
+ *		tags, false to stop.
  * @priv:	Will be passed as second argument to @fn.
  *
  * We grab one request reference before calling @fn and release it after

Re: [PATCH] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation

[Martin K. Petersen]

Bart,

> Commit 2dd6532e9591 ("blk-mq: Drop 'reserved' arg of busy_tag_iter_fn")
> removed the 'reserved' argument from tag iteration callback functions.
> Bring the blk_mq_tagset_busy_iter() documentation in sync with that
> change.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen

Re: [PATCH] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation

[Ming Lei]

On Tue, Sep 16, 2025 at 01:40:43PM -0700, Bart Van Assche wrote:
> Commit 2dd6532e9591 ("blk-mq: Drop 'reserved' arg of busy_tag_iter_fn")
> removed the 'reserved' argument from tag iteration callback functions.
> Bring the blk_mq_tagset_busy_iter() documentation in sync with that
> change.
> 
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: John Garry <john.g.garry@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Reviewed-by: Ming Lei <ming.lei@redhat.com>
 

Thanks,
Ming

Re: [PATCH] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation

[John Garry]

On 16/09/2025 21:40, Bart Van Assche wrote:
> Commit 2dd6532e9591 ("blk-mq: Drop 'reserved' arg of busy_tag_iter_fn")
> removed the 'reserved' argument from tag iteration callback functions.
> Bring the blk_mq_tagset_busy_iter() documentation in sync with that
> change.
> 
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: John Garry <john.g.garry@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>   block/blk-mq-tag.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index a63d21a4aab4..0602ca7f1e37 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -424,10 +424,9 @@ void blk_mq_all_tag_iter(struct blk_mq_tags *tags, busy_tag_iter_fn *fn,
>    * blk_mq_tagset_busy_iter - iterate over all started requests in a tag set
>    * @tagset:	Tag set to iterate over.
>    * @fn:		Pointer to the function that will be called for each started
> - *		request. @fn will be called as follows: @fn(rq, @priv,
> - *		reserved) where rq is a pointer to a request. 'reserved'
> - *		indicates whether or not @rq is a reserved request. Return
> - *		true to continue iterating tags, false to stop.
> + *		request. @fn will be called as follows: @fn(rq, @priv) where
> + *		rq is a pointer to a request. Return true to continue iterating
> + *		tags, false to stop.
>    * @priv:	Will be passed as second argument to @fn.
>    *
>    * We grab one request reference before calling @fn and release it after

I see other users of busy_tag_iter_fn which need the documentation 
updated, like blk_mq_queue_tag_busy_iter() and blk_mq_all_tag_iter(). 
Please consider updating them also, thanks

Re: [PATCH] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation

[Jens Axboe]

On Tue, 16 Sep 2025 13:40:43 -0700, Bart Van Assche wrote:
> Commit 2dd6532e9591 ("blk-mq: Drop 'reserved' arg of busy_tag_iter_fn")
> removed the 'reserved' argument from tag iteration callback functions.
> Bring the blk_mq_tagset_busy_iter() documentation in sync with that
> change.
> 
> 

Applied, thanks!

[1/1] blk-mq: Fix the blk_mq_tagset_busy_iter() documentation
      commit: 0b507305a08c134722f363de6fe6f1ba84e313b7

Best regards,
-- 
Jens Axboe