From: Keith Busch <kbusch@meta.com>
To: <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>
Cc: <axboe@kernel.dk>, <hch@lst.de>, <nilay@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv2 2/2] nvme: add support multipath passthrough iostats
Date: Tue, 26 May 2026 08:39:21 -0700 [thread overview]
Message-ID: <20260526153921.2402015-3-kbusch@meta.com> (raw)
In-Reply-To: <20260526153921.2402015-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
Don't skip io accounting for passthrough commands if the user enabled
tracking these.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/ioctl.c | 4 ++++
drivers/nvme/host/multipath.c | 5 ++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index 08889b20e5d8c..38ca04567406a 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -102,8 +102,12 @@ static struct request *nvme_alloc_user_request(struct request_queue *q,
struct nvme_command *cmd, blk_opf_t rq_flags,
blk_mq_req_flags_t blk_flags)
{
+ struct nvme_ns *ns = q->queuedata;
struct request *req;
+ if (ns && nvme_ns_head_multipath(ns->head))
+ rq_flags |= REQ_NVME_MPATH;
+
req = blk_mq_alloc_request(q, nvme_req_op(cmd) | rq_flags, blk_flags);
if (IS_ERR(req))
return req;
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 263161cb8ac06..d0a95cde181c4 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -175,9 +175,12 @@ void nvme_mpath_start_request(struct request *rq)
nvme_req(rq)->flags |= NVME_MPATH_CNT_ACTIVE;
}
- if (!blk_queue_io_stat(disk->queue) || blk_rq_is_passthrough(rq) ||
+ if (!blk_queue_io_stat(disk->queue) ||
(nvme_req(rq)->flags & NVME_MPATH_IO_STATS))
return;
+ if (blk_rq_is_passthrough(rq) &&
+ !blk_rq_passthrough_stats(rq, disk->queue))
+ return;
nvme_req(rq)->flags |= NVME_MPATH_IO_STATS;
nvme_req(rq)->start_time = bdev_start_io_acct(disk->part0, req_op(rq),
--
2.53.0-Meta
next prev parent reply other threads:[~2026-05-26 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:39 [PATCHv2 0/2] block, nvme: enable passthrough iostats Keith Busch
2026-05-26 15:39 ` [PATCHv2 1/2] block: export passthrough stats enabled Keith Busch
2026-05-27 6:15 ` Nilay Shroff
2026-05-27 6:46 ` Nitesh Shetty
2026-05-27 13:14 ` Christoph Hellwig
2026-05-27 13:22 ` Keith Busch
2026-05-27 13:28 ` Christoph Hellwig
2026-05-26 15:39 ` Keith Busch [this message]
2026-05-27 6:15 ` [PATCHv2 2/2] nvme: add support multipath passthrough iostats Nilay Shroff
2026-05-27 6:46 ` Nitesh Shetty
2026-05-27 13:16 ` Christoph Hellwig
2026-05-27 13:27 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526153921.2402015-3-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox