From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
axboe@kernel.dk, nilay@linux.ibm.com
Subject: Re: [PATCHv2 1/2] block: export passthrough stats enabled
Date: Wed, 27 May 2026 15:28:41 +0200 [thread overview]
Message-ID: <20260527132841.GA12022@lst.de> (raw)
In-Reply-To: <ahbwAxG1Pj2z3Q21@kbusch-mbp>
On Wed, May 27, 2026 at 07:22:11AM -0600, Keith Busch wrote:
> On Wed, May 27, 2026 at 03:14:58PM +0200, Christoph Hellwig wrote:
> > > +static inline bool blk_rq_passthrough_stats(struct request *req,
> > > + struct request_queue *q)
> >
> > The kerneldoc requested last time would be really nice to have.
> > Also, now that this is a public API killing the q argument and
> > just using req->q would make the API easier to understand.
>
> Oh, my missing kerneldoc is clearly a problem. We need a separate
> argument for the request_queue because the q we want to count stats for
> may not be the one providing the request.
Even more argument for having the documentation :)
next prev parent reply other threads:[~2026-05-27 13:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:39 [PATCHv2 0/2] block, nvme: enable passthrough iostats Keith Busch
2026-05-26 15:39 ` [PATCHv2 1/2] block: export passthrough stats enabled Keith Busch
2026-05-27 6:15 ` Nilay Shroff
2026-05-27 6:46 ` Nitesh Shetty
2026-05-27 13:14 ` Christoph Hellwig
2026-05-27 13:22 ` Keith Busch
2026-05-27 13:28 ` Christoph Hellwig [this message]
2026-05-26 15:39 ` [PATCHv2 2/2] nvme: add support multipath passthrough iostats Keith Busch
2026-05-27 6:15 ` Nilay Shroff
2026-05-27 6:46 ` Nitesh Shetty
2026-05-27 13:16 ` Christoph Hellwig
2026-05-27 13:27 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527132841.GA12022@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox