* [PATCH] ublk: add missing DEL_DEV_ASYNC to unprivileged permission check
@ 2026-09-01 14:24 Yitang Yang
2026-09-01 15:45 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Yitang Yang @ 2026-09-01 14:24 UTC (permalink / raw)
To: Ming Lei, Jens Axboe; +Cc: linux-block, Yitang Yang, stable
ublk_ctrl_uring_cmd_permission() is missing the UBLK_CMD_DEL_DEV_ASYNC
case, causing the command to always return -EINVAL for unprivileged
ublk devices. Fix it by adding the missing case.
Fixes: 13fe8e6825e4 ("ublk: add UBLK_CMD_DEL_DEV_ASYNC")
Cc: stable@vger.kernel.org
Signed-off-by: Yitang Yang <yi1tang.yang@gmail.com>
---
drivers/block/ublk_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 6c5bec7da97c..ade5d7fddd9d 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -5716,6 +5716,7 @@ static int ublk_ctrl_uring_cmd_permission(struct ublk_device *ub,
case UBLK_CMD_STOP_DEV:
case UBLK_CMD_ADD_DEV:
case UBLK_CMD_DEL_DEV:
+ case UBLK_CMD_DEL_DEV_ASYNC:
case UBLK_CMD_SET_PARAMS:
case UBLK_CMD_START_USER_RECOVERY:
case UBLK_CMD_END_USER_RECOVERY:
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ublk: add missing DEL_DEV_ASYNC to unprivileged permission check
2026-09-01 14:24 [PATCH] ublk: add missing DEL_DEV_ASYNC to unprivileged permission check Yitang Yang
@ 2026-09-01 15:45 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2026-09-01 15:45 UTC (permalink / raw)
To: Yitang Yang; +Cc: Jens Axboe, linux-block, stable
On Tue, Sep 1, 2026 at 9:25 AM Yitang Yang <yi1tang.yang@gmail.com> wrote:
>
> ublk_ctrl_uring_cmd_permission() is missing the UBLK_CMD_DEL_DEV_ASYNC
> case, causing the command to always return -EINVAL for unprivileged
> ublk devices. Fix it by adding the missing case.
>
> Fixes: 13fe8e6825e4 ("ublk: add UBLK_CMD_DEL_DEV_ASYNC")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yitang Yang <yi1tang.yang@gmail.com>
> ---
> drivers/block/ublk_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 6c5bec7da97c..ade5d7fddd9d 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -5716,6 +5716,7 @@ static int ublk_ctrl_uring_cmd_permission(struct ublk_device *ub,
> case UBLK_CMD_STOP_DEV:
> case UBLK_CMD_ADD_DEV:
> case UBLK_CMD_DEL_DEV:
> + case UBLK_CMD_DEL_DEV_ASYNC:
> case UBLK_CMD_SET_PARAMS:
> case UBLK_CMD_START_USER_RECOVERY:
> case UBLK_CMD_END_USER_RECOVERY:
Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Thanks,
Ming Lei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-01 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01 14:24 [PATCH] ublk: add missing DEL_DEV_ASYNC to unprivileged permission check Yitang Yang
2026-09-01 15:45 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox