From: John Garry <john.garry@linux.dev>
To: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, hch@lst.de
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
John Garry <john.garry@linux.dev>
Subject: [PATCH v4 0/4] fix NVMe multipath partition diskstats
Date: Mon, 21 Sep 2026 09:37:48 +0100 [thread overview]
Message-ID: <20260921083752.1154316-1-john.garry@linux.dev> (raw)
Currently the NVMe multipath partition diskstats are not maintained.
This is because the functionality to update the diskstats only updates
for the whole disk (and not per partition).
As an example:
$ ./fio_read nvme1n1p1 # run traffic on /dev/nvme1n1p1
...
$ more /proc/diskstats | grep nvme1
259 2 nvme1c1n1 49857 0 400344 768565 0 0 0 0 0 2334 768565 0 0 0 0 0 0
259 3 nvme1n1 99710 0 800680 1599285 0 0 0 0 0 2346 1599285 0 0 0 0 0 0
259 5 nvme1n1p1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
259 4 nvme1c2n1 49853 0 400336 831472 0 0 0 0 0 2315 831472 0 0 0 0 0 0
Notice how all values are 0 for nvme1n1p1.
This series addresses that problem by first updating the gendisk code to
create the partition table for hidden disks, as suggested by Keith.
This is done by cloning the partition table from the multipath disk.
Secondly the NVMe multipath functionality to handle the diskstats is
modified to handle the gendisk partition, by looking up this partition
from the per-path disk partition.
Difference to v3:
- Add block device operation disk changed CB
Difference to v2:
- don't scan per-path disk, and clone from multipath disk instead
John Garry (4):
block: support cloning partitions
block: don't show partition diskstats for GENHD_FL_HIDDEN
nvme-multipath: clone head disk partitions to per-path disks
nvme-multipath: fix diskstats for partitions
block/genhd.c | 3 +-
block/partitions/core.c | 43 ++++++++++++++++++
drivers/nvme/host/multipath.c | 83 ++++++++++++++++++++++++++++++-----
include/linux/blkdev.h | 2 +
4 files changed, 120 insertions(+), 11 deletions(-)
--
2.43.0
next reply other threads:[~2026-09-21 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 8:37 John Garry [this message]
2026-09-21 8:37 ` [PATCH v4 1/4] block: support cloning partitions John Garry
2026-09-21 8:37 ` [PATCH v4 2/4] block: don't show partition diskstats for GENHD_FL_HIDDEN John Garry
2026-09-21 8:37 ` [PATCH v4 3/4] nvme-multipath: clone head disk partitions to per-path disks John Garry
2026-09-21 8:37 ` [PATCH v4 4/4] nvme-multipath: fix diskstats for partitions John Garry
2026-09-28 7:30 ` [PATCH v4 0/4] fix NVMe multipath partition diskstats John Garry
2026-09-28 9:14 ` Christoph Hellwig
2026-09-28 10:16 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921083752.1154316-1-john.garry@linux.dev \
--to=john.garry@linux.dev \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox