From: John Garry <john.garry@linux.dev>
To: Christoph Hellwig <hch@lst.de>, John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v4 0/4] fix NVMe multipath partition diskstats
Date: Mon, 28 Sep 2026 11:16:59 +0100 [thread overview]
Message-ID: <2258be48-9e35-4139-b423-82400746db8c@linux.dev> (raw)
In-Reply-To: <20260928091428.GA29876@lst.de>
On 9/28/26 10:14, Christoph Hellwig wrote:
> On Mon, Sep 28, 2026 at 08:30:10AM +0100, John Garry wrote:
>> On 21/09/2026 09:37, John Garry wrote:
>>
>> A reminder on this one ... or are we just going to leave this broken?
>
> I find the amount of overhead and relatively invasive code very
> offputting, and I still don't understand why we now have a strong
> urge to address this after 10 years.
Nobody noticed (that the values are not maintained), I guess.
It may also be useful to have the per-path disk partition table in
future for other reasons.
Anyway, your call, so I'll leave it for now.
prev parent reply other threads:[~2026-09-28 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 8:37 [PATCH v4 0/4] fix NVMe multipath partition diskstats John Garry
2026-09-21 8:37 ` [PATCH v4 1/4] block: support cloning partitions John Garry
2026-09-21 8:37 ` [PATCH v4 2/4] block: don't show partition diskstats for GENHD_FL_HIDDEN John Garry
2026-09-21 8:37 ` [PATCH v4 3/4] nvme-multipath: clone head disk partitions to per-path disks John Garry
2026-09-21 8:37 ` [PATCH v4 4/4] nvme-multipath: fix diskstats for partitions John Garry
2026-09-28 7:30 ` [PATCH v4 0/4] fix NVMe multipath partition diskstats John Garry
2026-09-28 9:14 ` Christoph Hellwig
2026-09-28 10:16 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2258be48-9e35-4139-b423-82400746db8c@linux.dev \
--to=john.garry@linux.dev \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox