Re: [PATCH blktests 2/4] nvme/071: test that nvmet sends no data for a failed read

[Andrea Parri <parri.andrea@gmail.com>]

On Tue, Oct 20, 2026 at 07:35:53PM +0900, Shin'ichiro Kawasaki wrote:
> > +# Issue an Identify with CNS $2 to controller $1 and print the NVMe status
> > +# and the number of changed bytes in the 4096-byte data buffer.
> > +_identify() {
>
> In most cases, the function names that start with underscore are used for
> helper functions in common scripts. This function is used only in this script
> file, I suggest a function name that does not start with underscore. How about
> issue_identify() ?

Sure, issue_identify() it is.

> Do we really need this dd part below? As far as I understand, the core part of
> this test case is Identify command part above.

No, we don't.  It was meant as a control that the fc fix still sends
data for successful reads, but the successful Identify above already
checks that: it must overwrite the whole 4096-byte buffer.  I'll drop
the read, and with it the file backing, which was there only because
the read failed over the loop transport with the default backing.

Thanks,
Andrea