Linux block layer
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	 Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	 Chaitanya Kulkarni <kch@nvidia.com>,
	Daniel Wagner <dwagner@suse.de>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH blktests 0/4] nvme: add nvmet zone report and FC regression tests
Date: Tue, 20 Oct 2026 19:41:42 +0900	[thread overview]
Message-ID: <atdEpM1uAdi7Dnh1@shinmob> (raw)
In-Reply-To: <20261014170046.2516-1-parri.andrea@gmail.com>

On Oct 14, 2026 / 19:00, Andrea Parri wrote:
> Add regression tests for three nvmet bugs fixed by the kernel series
> "nvmet: fix stale data exposure and ZNS validation" [1]:
> 
>   nvme/071  "nvmet-fc: only send read data for successful commands"
>   nvme/072  "nvmet: zns: don't leak stale memory in zone management receive"
>   nvme/073  "nvmet: zns: reject a NUMD whose byte count wraps"
> 
> The nvme/072 fix is already applied to nvme-7.4; the other two are still
> under review.
> 
> Patch 1 adds the zoned null_blk target setup, cleanup and zone report
> status check that nvme/072 and nvme/073 share.  Patches 2-4 add one test
> each, with a small C helper for nvme/071 and nvme/072 where nvme-cli
> cannot express the check.
> 
> All three tests run on every configured transport.  On a kernel without
> the fixes, nvme/072 and nvme/073 fail over loop, tcp, rdma and fc, and
> nvme/071 fails over fc, the only affected transport.  All three pass
> with the fixes applied.
> 
> The tests take the next free numbers, nvme/071 to nvme/073.  If other
> nvme tests land first, I'm happy to renumber them and resend.
> 
> [1] https://lore.kernel.org/r/20261012141239.156408-1-parri.andrea@gmail.com

Andrea, thank you for this series. I ran the new test cases and they work as
expected. They all failed with the kernel v7.3, and they all passed with the
kernel fix patch series.

Overall, the patches in this series look good to me. I made some comments for
further improvement. Please check and see if they make sense for you.

  parent reply	other threads:[~2026-10-20 10:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 17:00 [PATCH blktests 0/4] nvme: add nvmet zone report and FC regression tests Andrea Parri
2026-10-14 17:00 ` [PATCH blktests 1/4] nvme/rc: add zoned null_blk target helpers Andrea Parri
2026-10-20 10:31   ` Shin'ichiro Kawasaki
2026-10-14 17:00 ` [PATCH blktests 2/4] nvme/071: test that nvmet sends no data for a failed read Andrea Parri
2026-10-20 10:35   ` Shin'ichiro Kawasaki
2026-10-20 15:17     ` Andrea Parri
2026-10-14 17:00 ` [PATCH blktests 3/4] nvme/072: test nvmet zone report initialization and length Andrea Parri
2026-10-20 10:38   ` Shin'ichiro Kawasaki
2026-10-14 17:00 ` [PATCH blktests 4/4] nvme/073: test that nvmet rejects a zone report NUMD that wraps Andrea Parri
2026-10-20 10:41 ` Shin'ichiro Kawasaki [this message]
2026-10-20 15:18   ` [PATCH blktests 0/4] nvme: add nvmet zone report and FC regression tests Andrea Parri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atdEpM1uAdi7Dnh1@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=dwagner@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=parri.andrea@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox