* Re: [PATCH 6.12 0534/1756] block: remove BLK_MQ_F_SHOULD_MERGE
[not found] <20261118150030.389817521@linuxfoundation.org>
@ 2026-11-19 14:08 ` Miguel Ojeda
0 siblings, 0 replies; only message in thread
From: Miguel Ojeda @ 2026-11-19 14:08 UTC (permalink / raw)
To: gregkh
Cc: axboe, hch, patches, sashal, stable, Andreas Hindborg, Boqun Feng,
linux-block, rust-for-linux
On Wed, 18 Nov 2026 15:44:21 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> BLK_MQ_F_SHOULD_MERGE is set for all tag_sets except those that purely
> process passthrough commands (bsg-lib, ufs tmf, various nvme admin
> queues) and thus don't even check the flag. Remove it to simplify the
> driver interface.
> enum {
> - BLK_MQ_F_SHOULD_MERGE = 1 << 0,
> BLK_MQ_F_TAG_QUEUE_SHARED = 1 << 1,
This causes:
error[E0425]: cannot find value `BLK_MQ_F_SHOULD_MERGE` in crate `bindings`
--> rust/kernel/block/mq/tag_set.rs:55:38
|
55 | flags: bindings::BLK_MQ_F_SHOULD_MERGE,
| ^^^^^^^^^^^^^^^^^^^^^ not found in `bindings`
We need:
31d813a3b8cb ("rust: block: fix use of BLK_MQ_F_SHOULD_MERGE")
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Andreas Hindborg <a.hindborg@kernel.org>
Cc: Boqun Feng <boqun@kernel.org>
Cc: linux-block@vger.kernel.org
Cc: rust-for-linux@vger.kernel.org
I hope that helps!
Cheers,
Miguel
^ permalink raw reply [flat|nested] only message in thread