From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/4] block: add rq_flags to struct blk_mq_alloc_data
Date: Tue, 19 Oct 2021 12:48:35 -0600 [thread overview]
Message-ID: <2635920a-2976-5ffa-6090-15d73968c0c8@kernel.dk> (raw)
In-Reply-To: <20211019184259.GD2083665@dhcp-10-100-145-180.wdc.com>
On 10/19/21 12:42 PM, Keith Busch wrote:
> On Tue, Oct 19, 2021 at 09:32:57AM -0600, Jens Axboe wrote:
>> There's a hole here we can use, and it's faster to set this earlier
>
> <snip>
>
>> @@ -148,6 +148,7 @@ struct blk_mq_alloc_data {
>> blk_mq_req_flags_t flags;
>> unsigned int shallow_depth;
>> unsigned int cmd_flags;
>> + unsigned int rq_flags;
>>
>> /* allocate multiple requests/tags in one go */
>> unsigned int nr_tags;
>
> The patch looks good, but the new field doesn't appear to occupy a hole.
Yes, not sure how I missed the first flags. I'll cut that from the commit
message.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-19 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 15:32 [PATCHSET 0/4] Last round of alloc side optimizations Jens Axboe
2021-10-19 15:32 ` [PATCH 1/4] block: add rq_flags to struct blk_mq_alloc_data Jens Axboe
2021-10-19 18:42 ` Keith Busch
2021-10-19 18:48 ` Jens Axboe [this message]
2021-11-03 19:54 ` Guenter Roeck
2021-11-03 19:56 ` Jens Axboe
2021-11-03 21:41 ` Guenter Roeck
2021-11-03 23:29 ` Jens Axboe
2021-10-19 15:32 ` [PATCH 2/4] block: pass in blk_mq_tags to blk_mq_rq_ctx_init() Jens Axboe
2021-10-19 15:32 ` [PATCH 3/4] block: prefetch request to be initialized Jens Axboe
2021-10-19 15:33 ` [PATCH 4/4] block: re-flow blk_mq_rq_ctx_init() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2635920a-2976-5ffa-6090-15d73968c0c8@kernel.dk \
--to=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox