From: Jens Axboe <axboe@kernel.dk>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-block@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] block: add rq_flags to struct blk_mq_alloc_data
Date: Wed, 3 Nov 2021 17:29:03 -0600 [thread overview]
Message-ID: <0f261885-9aae-79fc-02b0-689ffb9e444b@kernel.dk> (raw)
In-Reply-To: <20211103214113.GA3354463@roeck-us.net>
On 11/3/21 3:41 PM, Guenter Roeck wrote:
> On Wed, Nov 03, 2021 at 01:56:29PM -0600, Jens Axboe wrote:
>> On 11/3/21 1:54 PM, Guenter Roeck wrote:
>>> Hi,
>>>
>>> On Tue, Oct 19, 2021 at 09:32:57AM -0600, Jens Axboe wrote:
>>>> There's a hole here we can use, and it's faster to set this earlier
>>>> rather than need to check q->elevator multiple times.
>>>>
>>>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>>>
>>> This patch results in a warning backtrace with one of my qemu
>>> boot tests.
>>
>> Should be fixed in the current tree, will go out soonish. If you
>> have time, can you pull in:
>>
>> git://git.kernel.dk/linux-block for-next
>>
>> into -git and see if it fixes it for you?
>>
>
> Yes, it looks like the problem has been fixed in your for-next branch.
Great, thanks for testing.
--
Jens Axboe
next prev parent reply other threads:[~2021-11-03 23:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 15:32 [PATCHSET 0/4] Last round of alloc side optimizations Jens Axboe
2021-10-19 15:32 ` [PATCH 1/4] block: add rq_flags to struct blk_mq_alloc_data Jens Axboe
2021-10-19 18:42 ` Keith Busch
2021-10-19 18:48 ` Jens Axboe
2021-11-03 19:54 ` Guenter Roeck
2021-11-03 19:56 ` Jens Axboe
2021-11-03 21:41 ` Guenter Roeck
2021-11-03 23:29 ` Jens Axboe [this message]
2021-10-19 15:32 ` [PATCH 2/4] block: pass in blk_mq_tags to blk_mq_rq_ctx_init() Jens Axboe
2021-10-19 15:32 ` [PATCH 3/4] block: prefetch request to be initialized Jens Axboe
2021-10-19 15:33 ` [PATCH 4/4] block: re-flow blk_mq_rq_ctx_init() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f261885-9aae-79fc-02b0-689ffb9e444b@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox