From: Daniel Wagner <dwagner@suse.de>
To: John Garry <john.g.garry@oracle.com>
Cc: shinichiro.kawasaki@wdc.com, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, nilay@linux.ibm.com
Subject: Re: [PATCH blktests] nvme/068: add a test for multipath delayed removal
Date: Tue, 28 Apr 2026 14:42:28 +0200 [thread overview]
Message-ID: <328010ad-0d56-4f5e-a37a-e25914da08b5@flourine.local> (raw)
In-Reply-To: <2512cec3-31a8-4703-a50e-85289c860d25@oracle.com>
On Mon, Apr 27, 2026 at 01:51:17PM +0100, John Garry wrote:
> However some of what we want to test is still based on timing - for example,
> if we set delayed removal timeout to X seconds, we want to ensure that the
> gendisk is gone after X seconds. So we need the X second delay. Currently X
> is 10, but can shorten that.
>
> sound ok?
Sure, that's sounds reasonable.
For the gendisk removal case, I'd suggest to monitor if the disk goes
away within in a time limit instead of a simple sleep and then test. A
busy system might take slightly longer than usual. The time limit can
then be really high.
prev parent reply other threads:[~2026-04-28 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 10:41 [PATCH blktests] nvme/068: add a test for multipath delayed removal John Garry
2026-04-15 17:58 ` Chaitanya Kulkarni
2026-04-16 11:18 ` Nilay Shroff
2026-04-16 11:45 ` John Garry
2026-04-16 12:50 ` Shinichiro Kawasaki
2026-04-16 13:03 ` John Garry
2026-04-17 2:22 ` Shinichiro Kawasaki
2026-04-27 12:17 ` Daniel Wagner
2026-04-27 12:51 ` John Garry
2026-04-28 12:42 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=328010ad-0d56-4f5e-a37a-e25914da08b5@flourine.local \
--to=dwagner@suse.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox