From: Jens Axboe <axboe@kernel.dk>
To: SurajSonawane2415 <surajsonawane0215@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@infradead.org
Subject: Re: [PATCH V2] block: Fix elevator_get_default() to check for null q->tag_set
Date: Mon, 7 Oct 2024 14:24:19 -0600 [thread overview]
Message-ID: <4c310f0e-b677-4731-b827-df14b197545a@kernel.dk> (raw)
In-Reply-To: <20241007111416.13814-1-surajsonawane0215@gmail.com>
On 10/7/24 5:14 AM, SurajSonawane2415 wrote:
> Fix error "block/elevator.c:569 elevator_get_default() error:
> we previously assumed 'q->tag_set' could be null (see line 565)".
> Since 'q->tag_set' cannot be NULL for blk-mq queues,
> remove the unnecessary check in both `elevator_get_default`
> and `elv_support_iosched`. This simplifies the logic and
> ensures correct assumptions about 'q->tag_set' in blk-mq queues.
For future patches:
1) Wrap at 72 characters, your commit message is using shorter line
lengths.
2) Don't both with file numbers, they change all of the time. Digging
out an old commit with line numbers isn't very useful, you'd have to
rewind your tree for them to make sense.
I'll commit this, but rewrite the commit message somewhat.
--
Jens Axboe
next prev parent reply other threads:[~2024-10-07 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 12:39 [PATCH] block: Fix elevator_get_default() to check for null q->tag_set SurajSonawane2415
2024-10-07 5:53 ` Christoph Hellwig
2024-10-07 11:14 ` [PATCH V2] " SurajSonawane2415
2024-10-07 20:24 ` Jens Axboe [this message]
2024-10-07 20:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c310f0e-b677-4731-b827-df14b197545a@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surajsonawane0215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox